Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clipping far distance objects #80

Open
JChudinov opened this issue Oct 30, 2020 · 2 comments · Fixed by #86
Open

Clipping far distance objects #80

JChudinov opened this issue Oct 30, 2020 · 2 comments · Fixed by #86
Assignees
@cdytoby
Labels
bug Something isn't working

Comments

@JChudinov
Copy link

Hi! We using ur SDK in our app, where we have a couple of far distance objects. The matter is that in editor everyting works fine, yet on mobile devices (we tested samsung s7, s8, poco f1) objects placed further then ~110 units are invisible. It looks like a wrong value of clipping planes, but changing this value brought us no luck.

On this screens we have a brand new project with your SDK. Right behind the cube there is a plane and the result on mobile device u can see below. All parameters are in default state

image_2020_10_30T12_37_00_019Z

1604061375783
1604061388910
@JChudinov
Copy link
Author

we found solution here

#69

@cdytoby
Copy link
Collaborator

cdytoby commented Nov 4, 2020 •
edited
Loading

Thank you for the report and note.

I made a mistake on this one. Reopen this ticket for me:

Make variable for nearClip and farClip so that people can set it dynamically.

In Method CardboardLensDistortion.RefreshProjectionMatrix(), the near and far clip are not variable, which is not good.

@cdytoby cdytoby reopened this Nov 4, 2020
@cdytoby cdytoby self-assigned this Nov 4, 2020
@cdytoby cdytoby added the bug Something isn't working label Nov 4, 2020
@cdytoby cdytoby linked a pull request Nov 11, 2020 that will close this issue
Add method to set near and far clip. #86
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdytoby cdytoby

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add method to set near and far clip. mobfishgmbh/Cardboard-VR-Unity-SDK
2 participants
@JChudinov @cdytoby