BUG: Fix bug with coord frame reading #13129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
requested review from
alexrockhill,
agramfort,
mscheltienne,
dengemann and
jasmainak
as code owners
drammock
reviewed
Feb 25, 2025
drammock
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs in mne-bids
mainintroduced by #13083, see for example here. Short fix would have been to just change a.get(coord_frame)to.get(coord_frame, coord_frame), but then I realized we didn't fully test consistency of coord frame constant use. So this PR also cleans that up.Notably there are some coordinate frames that AFAIK we never use, so those have been singled out a couple of places here. But critically I added some tests to make sure three private constants that we use in many places are now internally consistent. We could in principle include these, but it will bloat all
_check_optionerrors that people see so I don't see much value. And these tests/comments will make it easy to add them later if we ever want them.