Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EEGLAB import (nodatchans) #13097

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Feb 3, 2025

Use a safe way to try and access eeg.chaninfo["nodatchans"]. Fixes #13094.

@drammock drammock enabled auto-merge (squash) February 3, 2025 16:23
@cbrnr
Copy link
Contributor Author

cbrnr commented Feb 3, 2025

The error is unrelated...

@cbrnr
Copy link
Contributor Author

cbrnr commented Feb 3, 2025

What's up with all those errors :-)? Seems like the docs error (mprof) is also not related...

@drammock
Copy link
Member

drammock commented Feb 3, 2025

docs problem is related:

/home/circleci/project/doc/<rst_prolog>:26: WARNING: py:obj reference target not found: nodatchans [ref.obj]

@cbrnr
Copy link
Contributor Author

cbrnr commented Feb 3, 2025

Ah of course, reST my old friend 😄.

@larsoner larsoner disabled auto-merge February 3, 2025 18:45
@larsoner
Copy link
Member

larsoner commented Feb 3, 2025

Thanks @cbrnr !

@larsoner larsoner merged commit 9e7fe95 into mne-tools:main Feb 3, 2025
28 of 30 checks passed
@cbrnr cbrnr deleted the eeglab-nodatchans branch February 9, 2025 10:08
larsoner added a commit to larsoner/mne-python that referenced this pull request Feb 11, 2025
* upstream/main:
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13110)
  ENH: add interpolate_to method (mne-tools#13044)
  add overwrite and verbose params to info.save (mne-tools#13107)
  Add support for n-dimensional arrays in `_tfr_from_mt` (mne-tools#13104)
  Skip first "New Segment" BrainVision marker (mne-tools#13100)
  MAINT: Use statsmodels pre and fix CircleCI (mne-tools#13106)
  Take units (m or mm) into account when showing fieldmaps on top of brains (mne-tools#13101)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13099)
  MAINT: Update code credit (mne-tools#13093)
  Fix EEGLAB import (nodatchans) (mne-tools#13097)
  MAINT: Fix CircleCI [circle deploy] (mne-tools#13089)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13088)
  Fix signature of some more _close() methods [circle deploy] (mne-tools#13087)
  Fix _close() on MNEAnnotationsFigure and MNESelectionFigure [circle deploy] (mne-tools#13086)
  BUG: Fix bug with Mesa 3D detection (mne-tools#13082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with mne.io.read_raw_eeglab in EEGLAB File Loading
3 participants