From 48cadad95b99cf8fd2bf38118daccaaa0a11d83e Mon Sep 17 00:00:00 2001 From: btkcodedev Date: Tue, 26 Dec 2023 20:11:44 +0530 Subject: [PATCH 01/10] chore: update preprocessing tutorial for using inst.pick() instead of pick_types() Updated the tutorial by removing legacy method call of mne.io.Raw.pick_types() to instance.pick() --- tutorials/preprocessing/15_handling_bad_channels.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorials/preprocessing/15_handling_bad_channels.py b/tutorials/preprocessing/15_handling_bad_channels.py index daac97976a5..93ed1591333 100644 --- a/tutorials/preprocessing/15_handling_bad_channels.py +++ b/tutorials/preprocessing/15_handling_bad_channels.py @@ -239,7 +239,7 @@ # %% # Note that we used the ``exclude=[]`` trick in the call to -# :meth:`~mne.io.Raw.pick_types` to make sure the bad channels were not +# :meth:`pick()` method from the instance of `~mne.io.Raw` to make sure the bad channels were not # automatically dropped from the selection. Here is the corresponding example # with the interpolated gradiometer channel; since there are more channels # we'll use a more transparent gray color this time: From b5cf7801e7d8d5b157e03dcd81c828d51c1bd16d Mon Sep 17 00:00:00 2001 From: btkcodedev Date: Sat, 30 Dec 2023 12:08:10 +0530 Subject: [PATCH 02/10] Update tutorials/preprocessing/15_handling_bad_channels.py Co-authored-by: Marijn van Vliet --- tutorials/preprocessing/15_handling_bad_channels.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorials/preprocessing/15_handling_bad_channels.py b/tutorials/preprocessing/15_handling_bad_channels.py index 93ed1591333..39689a75be2 100644 --- a/tutorials/preprocessing/15_handling_bad_channels.py +++ b/tutorials/preprocessing/15_handling_bad_channels.py @@ -239,7 +239,7 @@ # %% # Note that we used the ``exclude=[]`` trick in the call to -# :meth:`pick()` method from the instance of `~mne.io.Raw` to make sure the bad channels were not +# :meth:`~mne.io.Raw.pick()` to make sure the bad channels were not # automatically dropped from the selection. Here is the corresponding example # with the interpolated gradiometer channel; since there are more channels # we'll use a more transparent gray color this time: From f7c59cbbd16c03188df263d4e2530cac5f59c562 Mon Sep 17 00:00:00 2001 From: btkcodedev Date: Sat, 30 Dec 2023 12:10:06 +0530 Subject: [PATCH 03/10] Update 15_handling_bad_channels.py --- tutorials/preprocessing/15_handling_bad_channels.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorials/preprocessing/15_handling_bad_channels.py b/tutorials/preprocessing/15_handling_bad_channels.py index 39689a75be2..3120bb77522 100644 --- a/tutorials/preprocessing/15_handling_bad_channels.py +++ b/tutorials/preprocessing/15_handling_bad_channels.py @@ -238,7 +238,7 @@ fig.suptitle(title, size="xx-large", weight="bold") # %% -# Note that we used the ``exclude=[]`` trick in the call to +# Note that we called the method: # :meth:`~mne.io.Raw.pick()` to make sure the bad channels were not # automatically dropped from the selection. Here is the corresponding example # with the interpolated gradiometer channel; since there are more channels From 16f6d6c14a2ceec07406f15fd37e22630509b6c1 Mon Sep 17 00:00:00 2001 From: btkcodedev Date: Thu, 11 Jan 2024 07:40:50 +0530 Subject: [PATCH 04/10] Update tutorials/preprocessing/15_handling_bad_channels.py Co-authored-by: Mathieu Scheltienne --- tutorials/preprocessing/15_handling_bad_channels.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tutorials/preprocessing/15_handling_bad_channels.py b/tutorials/preprocessing/15_handling_bad_channels.py index 3120bb77522..a3a0fa9787a 100644 --- a/tutorials/preprocessing/15_handling_bad_channels.py +++ b/tutorials/preprocessing/15_handling_bad_channels.py @@ -238,8 +238,9 @@ fig.suptitle(title, size="xx-large", weight="bold") # %% -# Note that we called the method: -# :meth:`~mne.io.Raw.pick()` to make sure the bad channels were not +# Note that the method :meth:`~mne.io.Raw.pick()` default +# arguments includes `exclude=()` which ensures that bad +# channels are not # automatically dropped from the selection. Here is the corresponding example # with the interpolated gradiometer channel; since there are more channels # we'll use a more transparent gray color this time: From ea31ce68f31997e13a6287a2f581000951f8e654 Mon Sep 17 00:00:00 2001 From: btkcodedev Date: Thu, 11 Jan 2024 07:45:19 +0530 Subject: [PATCH 05/10] Update names.inc --- doc/changes/names.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/changes/names.inc b/doc/changes/names.inc index f1a0c951da4..0e9757b1547 100644 --- a/doc/changes/names.inc +++ b/doc/changes/names.inc @@ -66,6 +66,8 @@ .. _Britta Westner: https://britta-wstnr.github.io +.. _Balasubramanian T K: https://github.com/btkcodedev + .. _Bruno Nicenboim: https://bnicenboim.github.io .. _buildqa: https://github.com/buildqa From b0da613d5563be0eaa3547698174cbcdae55300a Mon Sep 17 00:00:00 2001 From: btkcodedev Date: Thu, 11 Jan 2024 07:49:01 +0530 Subject: [PATCH 06/10] Create 12326.other.rst --- doc/changes/devel/12326.other.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changes/devel/12326.other.rst diff --git a/doc/changes/devel/12326.other.rst b/doc/changes/devel/12326.other.rst new file mode 100644 index 00000000000..6586ee0e8f0 --- /dev/null +++ b/doc/changes/devel/12326.other.rst @@ -0,0 +1 @@ +Updated preprocessing tutorial for using inst.pick() instead of pick_types() entries, by `btkcodedev`_. From 770fc3ef46997c86186cfd77a3dcf07fd98df9f1 Mon Sep 17 00:00:00 2001 From: btkcodedev Date: Sat, 20 Jan 2024 20:16:43 +0530 Subject: [PATCH 07/10] Update doc/changes/devel/12326.other.rst Co-authored-by: Mathieu Scheltienne --- doc/changes/devel/12326.other.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/changes/devel/12326.other.rst b/doc/changes/devel/12326.other.rst index 6586ee0e8f0..b8f2966bbf9 100644 --- a/doc/changes/devel/12326.other.rst +++ b/doc/changes/devel/12326.other.rst @@ -1 +1 @@ -Updated preprocessing tutorial for using inst.pick() instead of pick_types() entries, by `btkcodedev`_. +Updated the text in the preprocessing tutorial to use :class:`mne.io.Raw.pick()` instead of the legacy :class:`mne.io.Raw.pick_types()`, by :newcontrib:`btkcodedev`. From 6a0db7ec8bb8c76b1c7bfa38b2686b1fa8bb458d Mon Sep 17 00:00:00 2001 From: btkcodedev Date: Sat, 20 Jan 2024 20:18:29 +0530 Subject: [PATCH 08/10] Update names.inc --- doc/changes/names.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/changes/names.inc b/doc/changes/names.inc index 1b253efac84..0389f75e83e 100644 --- a/doc/changes/names.inc +++ b/doc/changes/names.inc @@ -66,10 +66,10 @@ .. _Britta Westner: https://britta-wstnr.github.io -.. _Balasubramanian T K: https://github.com/btkcodedev - .. _Bruno Nicenboim: https://bnicenboim.github.io +.. _btkcodedev: https://github.com/btkcodedev + .. _buildqa: https://github.com/buildqa .. _Carlos de la Torre-Ortiz: https://ctorre.me From 4fdd5a08674b434e466876291ecdb8d1c3ac5e0f Mon Sep 17 00:00:00 2001 From: Mathieu Scheltienne Date: Mon, 22 Jan 2024 12:06:35 +0100 Subject: [PATCH 09/10] trigger cis From 6f5408b5fcc5d77046c4e1a0c8f679fdf94538a4 Mon Sep 17 00:00:00 2001 From: Mathieu Scheltienne Date: Wed, 24 Jan 2024 15:39:55 +0100 Subject: [PATCH 10/10] fix typo --- tutorials/preprocessing/15_handling_bad_channels.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorials/preprocessing/15_handling_bad_channels.py b/tutorials/preprocessing/15_handling_bad_channels.py index a3a0fa9787a..06e9ffd6e53 100644 --- a/tutorials/preprocessing/15_handling_bad_channels.py +++ b/tutorials/preprocessing/15_handling_bad_channels.py @@ -239,7 +239,7 @@ # %% # Note that the method :meth:`~mne.io.Raw.pick()` default -# arguments includes `exclude=()` which ensures that bad +# arguments includes ``exclude=()`` which ensures that bad # channels are not # automatically dropped from the selection. Here is the corresponding example # with the interpolated gradiometer channel; since there are more channels