Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FixedImageView doesn't update if url is changed by parent view after it appears #1263

Closed
Sjmarf opened this issue Aug 27, 2024 · 3 comments · Fixed by #1782
Closed

FixedImageView doesn't update if url is changed by parent view after it appears #1263

Sjmarf opened this issue Aug 27, 2024 · 3 comments · Fixed by #1782
Assignees
@EricBAndrews
Milestone
v2.0

Comments

@Sjmarf
Copy link
Member

Sjmarf commented Aug 27, 2024

No description provided.

@Sjmarf Sjmarf added the bug label Aug 27, 2024
@Sjmarf Sjmarf added this to the v2.0 milestone Jan 16, 2025
@Sjmarf Sjmarf added technical debt and removed bug labels Jan 16, 2025
@Sjmarf
Copy link
Member Author

Sjmarf commented Jan 16, 2025

I tried to fix this a while ago but didn't get anywhere. The workaround I've been using is to .id() the FixedImageView with the url but this isn't ideal

@Sjmarf Sjmarf changed the title [2.0] FixedImageView doesn't update if url is changed by parent view after it appears FixedImageView doesn't update if url is changed by parent view after it appears Jan 16, 2025
@Sjmarf Sjmarf added bug and removed bug labels Jan 16, 2025
@EricBAndrews EricBAndrews self-assigned this Feb 12, 2025
@EricBAndrews
Copy link
Member

Workaround in place on:

  • LoginCredentialsView:103
  • PersonBanEditorView:157

@EricBAndrews EricBAndrews mentioned this issue Feb 12, 2025
Open
@EricBAndrews EricBAndrews changed the title FixedImageView doesn't update if url is changed by parent view after it appears Media Views don't update if url is changed by parent view after it appears Feb 20, 2025
@EricBAndrews
Copy link
Member

EricBAndrews commented Feb 20, 2025 •
edited
Loading

Issue is also present in MediaView, but doesn't appear to affect the app anywhere since the nil -> defined case isn't possible. Updated #1737 to reflect this.

@EricBAndrews EricBAndrews changed the title Media Views don't update if url is changed by parent view after it appears FixedImageView doesn't update if url is changed by parent view after it appears Feb 21, 2025
@EricBAndrews EricBAndrews mentioned this issue Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricBAndrews EricBAndrews

Labels
None yet
Projects
No open projects
Development Tracker
Status: To Triage
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Update FixedImageView when URL updates mlemgroup/mlem
2 participants
@EricBAndrews @Sjmarf