Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create explicit docker network #1

Open
mathematicalmichael opened this issue Apr 22, 2022 · 0 comments
Open

create explicit docker network #1

mathematicalmichael opened this issue Apr 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@mathematicalmichael
Copy link
Member

mathematicalmichael commented Apr 22, 2022

problem:

if the repo is renamed (or the folder into which it is cloned is renamed), docker-compose will change the name of the default network that is created and functionally break make serve.

solution:

  • make network as a dependency to create an explicit external network and reference it in the docker-compose file
  • understand how default network can be renamed to something within docker-compose.yml (i.e., avoid external network with Makefile) and give it an explicit name.
@mathematicalmichael mathematicalmichael added the enhancement New feature or request label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant