Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder Generalization Issue for Automators #139

Open
anmol-srivastava-mitre opened this issue Mar 2, 2023 · 1 comment
Open

Placeholder Generalization Issue for Automators #139

anmol-srivastava-mitre opened this issue Mar 2, 2023 · 1 comment

Comments

@anmol-srivastava-mitre
Copy link
Contributor

In case we decide Injector automator classes/code can be improved / generalized. Specifically many injectors share common arguments / patterns but have some extra attributes, making it difficult to standardize code that calls on them. We may want to address this via e.g. moving common steps to the __init__ call and making use of kwargs, etc. in the __call__ portion.

@Anmol-Srivastava
Copy link
Contributor

Anmol-Srivastava commented Mar 7, 2023

class NewInjector():
    def __init__(self, common_params):
        super().__init__()

    def __call__(self, **kwargs):
        # this erases the documentation of the specific arguments, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants