From 1c6ccb309ddfd3436475a16364b410281fbe86f4 Mon Sep 17 00:00:00 2001 From: Marie Date: Mon, 3 Feb 2025 01:13:21 +0000 Subject: [PATCH 01/10] fix: disallow corepack from fetching latest manager version instead use specified version in package.json --- Dockerfile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Dockerfile b/Dockerfile index 13f690946285..eef419052d81 100644 --- a/Dockerfile +++ b/Dockerfile @@ -6,6 +6,8 @@ ARG NODE_VERSION=22.11.0-bookworm FROM --platform=$BUILDPLATFORM node:${NODE_VERSION} AS native-builder +ENV COREPACK_DEFAULT_TO_LATEST=0 + RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \ --mount=type=cache,target=/var/lib/apt,sharing=locked \ rm -f /etc/apt/apt.conf.d/docker-clean \ @@ -68,6 +70,7 @@ FROM --platform=$TARGETPLATFORM node:${NODE_VERSION}-slim AS runner ARG UID="991" ARG GID="991" +ENV COREPACK_DEFAULT_TO_LATEST=0 RUN apt-get update \ && apt-get install -y --no-install-recommends \ From ade0ae19ab9283d4a7e8a58b7b7b59dbcb6a5f08 Mon Sep 17 00:00:00 2001 From: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> Date: Mon, 3 Feb 2025 11:38:28 +0900 Subject: [PATCH 02/10] Update Changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 601bf743bc70..b2053fad1c92 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,8 @@ ## 2025.2.0 ### General -- +- Fix: Docker のビルドに失敗する問題を修正 + (Cherry-picked from https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/883) ### Client - Fix: 一部環境でセンシティブなファイルを含むノートの非表示が効かない問題 From 3145d61e2caf1952c40b96cde9f1bedb48bb53bc Mon Sep 17 00:00:00 2001 From: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> Date: Mon, 3 Feb 2025 11:43:52 +0900 Subject: [PATCH 03/10] fix? --- Dockerfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Dockerfile b/Dockerfile index eef419052d81..3bc2044396bd 100644 --- a/Dockerfile +++ b/Dockerfile @@ -46,6 +46,8 @@ RUN rm -rf .git/ FROM --platform=$TARGETPLATFORM node:${NODE_VERSION} AS target-builder +ENV COREPACK_DEFAULT_TO_LATEST=0 + RUN apt-get update \ && apt-get install -yqq --no-install-recommends \ build-essential From 67f0dc31adaa04f891f74f5c44a3d4d13a302a03 Mon Sep 17 00:00:00 2001 From: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> Date: Mon, 3 Feb 2025 11:52:29 +0900 Subject: [PATCH 04/10] apply COREPACK_DEFAULT_TO_LATEST: 0 to every github workflows --- .github/workflows/api-misskey-js.yml | 2 ++ .github/workflows/get-api-diff.yml | 2 ++ .github/workflows/lint.yml | 6 ++++++ .github/workflows/locale.yml | 2 ++ .github/workflows/on-release-created.yml | 1 + .github/workflows/storybook.yml | 2 ++ .github/workflows/test-backend.yml | 4 ++++ .github/workflows/test-federation.yml | 2 ++ .github/workflows/test-frontend.yml | 4 ++++ .github/workflows/test-misskey-js.yml | 2 ++ .github/workflows/test-production.yml | 2 ++ .github/workflows/validate-api-json.yml | 2 ++ 12 files changed, 31 insertions(+) diff --git a/.github/workflows/api-misskey-js.yml b/.github/workflows/api-misskey-js.yml index e21738c4f4a8..be96c61483b1 100644 --- a/.github/workflows/api-misskey-js.yml +++ b/.github/workflows/api-misskey-js.yml @@ -19,6 +19,8 @@ jobs: uses: actions/checkout@v4.1.1 - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - name: Setup Node.js uses: actions/setup-node@v4.1.0 diff --git a/.github/workflows/get-api-diff.yml b/.github/workflows/get-api-diff.yml index 46c726b986c9..2a5afc06bc7c 100644 --- a/.github/workflows/get-api-diff.yml +++ b/.github/workflows/get-api-diff.yml @@ -38,6 +38,8 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 9785bb5744dc..8c77fa0a6b81 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -42,6 +42,8 @@ jobs: node-version-file: '.node-version' cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile lint: @@ -73,6 +75,8 @@ jobs: node-version-file: '.node-version' cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Restore eslint cache uses: actions/cache@v4.2.0 @@ -103,6 +107,8 @@ jobs: node-version-file: '.node-version' cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - run: pnpm --filter misskey-js run build if: ${{ matrix.workspace == 'backend' || matrix.workspace == 'sw' }} diff --git a/.github/workflows/locale.yml b/.github/workflows/locale.yml index 2eb4ca3ad93c..9ecb9092b31d 100644 --- a/.github/workflows/locale.yml +++ b/.github/workflows/locale.yml @@ -24,5 +24,7 @@ jobs: node-version-file: '.node-version' cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - run: cd locales && node verify.js diff --git a/.github/workflows/on-release-created.yml b/.github/workflows/on-release-created.yml index 8ca2ed9efb8c..b108471633ed 100644 --- a/.github/workflows/on-release-created.yml +++ b/.github/workflows/on-release-created.yml @@ -38,5 +38,6 @@ jobs: pnpm build pnpm --filter misskey-js publish --access public --no-git-checks --provenance env: + COREPACK_DEFAULT_TO_LATEST: 0 NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }} NPM_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }} diff --git a/.github/workflows/storybook.yml b/.github/workflows/storybook.yml index dfba46a8c800..e81998e6ba85 100644 --- a/.github/workflows/storybook.yml +++ b/.github/workflows/storybook.yml @@ -48,6 +48,8 @@ jobs: node-version-file: '.node-version' cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml diff --git a/.github/workflows/test-backend.yml b/.github/workflows/test-backend.yml index debfe24819ca..816df344ba9e 100644 --- a/.github/workflows/test-backend.yml +++ b/.github/workflows/test-backend.yml @@ -67,6 +67,8 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml @@ -115,6 +117,8 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml diff --git a/.github/workflows/test-federation.yml b/.github/workflows/test-federation.yml index c4546a0590c7..b90970164514 100644 --- a/.github/workflows/test-federation.yml +++ b/.github/workflows/test-federation.yml @@ -53,6 +53,8 @@ jobs: corepack enable && corepack prepare pnpm i --frozen-lockfile pnpm build + env: + COREPACK_DEFAULT_TO_LATEST: 0 - name: Setup run: | cd packages/backend/test-federation diff --git a/.github/workflows/test-frontend.yml b/.github/workflows/test-frontend.yml index 51e0b0e8b8a4..cea0406c4a6b 100644 --- a/.github/workflows/test-frontend.yml +++ b/.github/workflows/test-frontend.yml @@ -43,6 +43,8 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml @@ -99,6 +101,8 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Copy Configure run: cp .github/misskey/test.yml .config diff --git a/.github/workflows/test-misskey-js.yml b/.github/workflows/test-misskey-js.yml index c72a2470a474..fb305798fa56 100644 --- a/.github/workflows/test-misskey-js.yml +++ b/.github/workflows/test-misskey-js.yml @@ -30,6 +30,8 @@ jobs: uses: actions/checkout@v4.1.1 - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - name: Setup Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4.1.0 diff --git a/.github/workflows/test-production.yml b/.github/workflows/test-production.yml index 4a55f4803c88..b56ccc61b52a 100644 --- a/.github/workflows/test-production.yml +++ b/.github/workflows/test-production.yml @@ -31,6 +31,8 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml diff --git a/.github/workflows/validate-api-json.yml b/.github/workflows/validate-api-json.yml index 0d254898f8a2..f98504fabcae 100644 --- a/.github/workflows/validate-api-json.yml +++ b/.github/workflows/validate-api-json.yml @@ -34,6 +34,8 @@ jobs: - name: Install Redocly CLI run: npm i -g @redocly/cli - run: corepack enable + env: + COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml From 432c231052609227db0340e5dbc19b6294eaa271 Mon Sep 17 00:00:00 2001 From: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> Date: Mon, 3 Feb 2025 11:54:15 +0900 Subject: [PATCH 05/10] Revert "apply COREPACK_DEFAULT_TO_LATEST: 0 to every github workflows" This reverts commit 67f0dc31adaa04f891f74f5c44a3d4d13a302a03. --- .github/workflows/api-misskey-js.yml | 2 -- .github/workflows/get-api-diff.yml | 2 -- .github/workflows/lint.yml | 6 ------ .github/workflows/locale.yml | 2 -- .github/workflows/on-release-created.yml | 1 - .github/workflows/storybook.yml | 2 -- .github/workflows/test-backend.yml | 4 ---- .github/workflows/test-federation.yml | 2 -- .github/workflows/test-frontend.yml | 4 ---- .github/workflows/test-misskey-js.yml | 2 -- .github/workflows/test-production.yml | 2 -- .github/workflows/validate-api-json.yml | 2 -- 12 files changed, 31 deletions(-) diff --git a/.github/workflows/api-misskey-js.yml b/.github/workflows/api-misskey-js.yml index be96c61483b1..e21738c4f4a8 100644 --- a/.github/workflows/api-misskey-js.yml +++ b/.github/workflows/api-misskey-js.yml @@ -19,8 +19,6 @@ jobs: uses: actions/checkout@v4.1.1 - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - name: Setup Node.js uses: actions/setup-node@v4.1.0 diff --git a/.github/workflows/get-api-diff.yml b/.github/workflows/get-api-diff.yml index 2a5afc06bc7c..46c726b986c9 100644 --- a/.github/workflows/get-api-diff.yml +++ b/.github/workflows/get-api-diff.yml @@ -38,8 +38,6 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 8c77fa0a6b81..9785bb5744dc 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -42,8 +42,6 @@ jobs: node-version-file: '.node-version' cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile lint: @@ -75,8 +73,6 @@ jobs: node-version-file: '.node-version' cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Restore eslint cache uses: actions/cache@v4.2.0 @@ -107,8 +103,6 @@ jobs: node-version-file: '.node-version' cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - run: pnpm --filter misskey-js run build if: ${{ matrix.workspace == 'backend' || matrix.workspace == 'sw' }} diff --git a/.github/workflows/locale.yml b/.github/workflows/locale.yml index 9ecb9092b31d..2eb4ca3ad93c 100644 --- a/.github/workflows/locale.yml +++ b/.github/workflows/locale.yml @@ -24,7 +24,5 @@ jobs: node-version-file: '.node-version' cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - run: cd locales && node verify.js diff --git a/.github/workflows/on-release-created.yml b/.github/workflows/on-release-created.yml index b108471633ed..8ca2ed9efb8c 100644 --- a/.github/workflows/on-release-created.yml +++ b/.github/workflows/on-release-created.yml @@ -38,6 +38,5 @@ jobs: pnpm build pnpm --filter misskey-js publish --access public --no-git-checks --provenance env: - COREPACK_DEFAULT_TO_LATEST: 0 NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }} NPM_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }} diff --git a/.github/workflows/storybook.yml b/.github/workflows/storybook.yml index e81998e6ba85..dfba46a8c800 100644 --- a/.github/workflows/storybook.yml +++ b/.github/workflows/storybook.yml @@ -48,8 +48,6 @@ jobs: node-version-file: '.node-version' cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml diff --git a/.github/workflows/test-backend.yml b/.github/workflows/test-backend.yml index 816df344ba9e..debfe24819ca 100644 --- a/.github/workflows/test-backend.yml +++ b/.github/workflows/test-backend.yml @@ -67,8 +67,6 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml @@ -117,8 +115,6 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml diff --git a/.github/workflows/test-federation.yml b/.github/workflows/test-federation.yml index b90970164514..c4546a0590c7 100644 --- a/.github/workflows/test-federation.yml +++ b/.github/workflows/test-federation.yml @@ -53,8 +53,6 @@ jobs: corepack enable && corepack prepare pnpm i --frozen-lockfile pnpm build - env: - COREPACK_DEFAULT_TO_LATEST: 0 - name: Setup run: | cd packages/backend/test-federation diff --git a/.github/workflows/test-frontend.yml b/.github/workflows/test-frontend.yml index cea0406c4a6b..51e0b0e8b8a4 100644 --- a/.github/workflows/test-frontend.yml +++ b/.github/workflows/test-frontend.yml @@ -43,8 +43,6 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml @@ -101,8 +99,6 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Copy Configure run: cp .github/misskey/test.yml .config diff --git a/.github/workflows/test-misskey-js.yml b/.github/workflows/test-misskey-js.yml index fb305798fa56..c72a2470a474 100644 --- a/.github/workflows/test-misskey-js.yml +++ b/.github/workflows/test-misskey-js.yml @@ -30,8 +30,6 @@ jobs: uses: actions/checkout@v4.1.1 - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - name: Setup Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4.1.0 diff --git a/.github/workflows/test-production.yml b/.github/workflows/test-production.yml index b56ccc61b52a..4a55f4803c88 100644 --- a/.github/workflows/test-production.yml +++ b/.github/workflows/test-production.yml @@ -31,8 +31,6 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'pnpm' - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml diff --git a/.github/workflows/validate-api-json.yml b/.github/workflows/validate-api-json.yml index f98504fabcae..0d254898f8a2 100644 --- a/.github/workflows/validate-api-json.yml +++ b/.github/workflows/validate-api-json.yml @@ -34,8 +34,6 @@ jobs: - name: Install Redocly CLI run: npm i -g @redocly/cli - run: corepack enable - env: - COREPACK_DEFAULT_TO_LATEST: 0 - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml From ebd777761d727a65130776727ba070fe441f3422 Mon Sep 17 00:00:00 2001 From: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> Date: Mon, 3 Feb 2025 11:58:21 +0900 Subject: [PATCH 06/10] apply COREPACK_DEFAULT_TO_LATEST: 0 to every github workflows (re) --- .github/workflows/api-misskey-js.yml | 4 ++++ .github/workflows/get-api-diff.yml | 4 ++++ .github/workflows/lint.yml | 4 ++++ .github/workflows/locale.yml | 4 ++++ .github/workflows/on-release-created.yml | 3 +++ .github/workflows/storybook.yml | 1 + .github/workflows/test-backend.yml | 4 ++++ .github/workflows/test-federation.yml | 3 +++ .github/workflows/test-frontend.yml | 4 ++++ .github/workflows/test-misskey-js.yml | 4 ++++ .github/workflows/test-production.yml | 1 + .github/workflows/validate-api-json.yml | 4 ++++ 12 files changed, 40 insertions(+) diff --git a/.github/workflows/api-misskey-js.yml b/.github/workflows/api-misskey-js.yml index e21738c4f4a8..6f4219b54b32 100644 --- a/.github/workflows/api-misskey-js.yml +++ b/.github/workflows/api-misskey-js.yml @@ -9,6 +9,10 @@ on: paths: - packages/misskey-js/** - .github/workflows/api-misskey-js.yml + +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: report: diff --git a/.github/workflows/get-api-diff.yml b/.github/workflows/get-api-diff.yml index 46c726b986c9..6805e8bc3c5c 100644 --- a/.github/workflows/get-api-diff.yml +++ b/.github/workflows/get-api-diff.yml @@ -9,6 +9,10 @@ on: paths: - packages/backend/** - .github/workflows/get-api-diff.yml + +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: get-from-misskey: runs-on: ubuntu-latest diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 9785bb5744dc..2f6938d2e43b 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -28,6 +28,10 @@ on: - packages/misskey-reversi/** - packages/shared/eslint.config.js - .github/workflows/lint.yml + +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: pnpm_install: runs-on: ubuntu-latest diff --git a/.github/workflows/locale.yml b/.github/workflows/locale.yml index 2eb4ca3ad93c..95d29bf828c6 100644 --- a/.github/workflows/locale.yml +++ b/.github/workflows/locale.yml @@ -9,6 +9,10 @@ on: paths: - locales/** - .github/workflows/locale.yml + +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: locale_verify: runs-on: ubuntu-latest diff --git a/.github/workflows/on-release-created.yml b/.github/workflows/on-release-created.yml index 8ca2ed9efb8c..fc224a62395b 100644 --- a/.github/workflows/on-release-created.yml +++ b/.github/workflows/on-release-created.yml @@ -6,6 +6,9 @@ on: workflow_dispatch: +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: publish-misskey-js: name: Publish misskey-js diff --git a/.github/workflows/storybook.yml b/.github/workflows/storybook.yml index dfba46a8c800..f97b9b6d8d8c 100644 --- a/.github/workflows/storybook.yml +++ b/.github/workflows/storybook.yml @@ -21,6 +21,7 @@ jobs: env: NODE_OPTIONS: "--max_old_space_size=7168" + COREPACK_DEFAULT_TO_LATEST: 0 steps: - uses: actions/checkout@v4.1.1 diff --git a/.github/workflows/test-backend.yml b/.github/workflows/test-backend.yml index debfe24819ca..99a9f99b7599 100644 --- a/.github/workflows/test-backend.yml +++ b/.github/workflows/test-backend.yml @@ -18,6 +18,10 @@ on: - packages/misskey-js/** - .github/workflows/test-backend.yml - .github/misskey/test.yml + +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: unit: name: Unit tests (backend) diff --git a/.github/workflows/test-federation.yml b/.github/workflows/test-federation.yml index c4546a0590c7..74cdff80f11b 100644 --- a/.github/workflows/test-federation.yml +++ b/.github/workflows/test-federation.yml @@ -15,6 +15,9 @@ on: - packages/misskey-js/** - .github/workflows/test-federation.yml +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: test: name: Federation test diff --git a/.github/workflows/test-frontend.yml b/.github/workflows/test-frontend.yml index 51e0b0e8b8a4..6c09896d0609 100644 --- a/.github/workflows/test-frontend.yml +++ b/.github/workflows/test-frontend.yml @@ -22,6 +22,10 @@ on: - packages/backend/** - .github/workflows/test-frontend.yml - .github/misskey/test.yml + +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: vitest: name: Unit tests (frontend) diff --git a/.github/workflows/test-misskey-js.yml b/.github/workflows/test-misskey-js.yml index c72a2470a474..d88dc18bd804 100644 --- a/.github/workflows/test-misskey-js.yml +++ b/.github/workflows/test-misskey-js.yml @@ -14,6 +14,10 @@ on: paths: - packages/misskey-js/** - .github/workflows/test-misskey-js.yml + +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: test: name: Unit tests (misskey.js) diff --git a/.github/workflows/test-production.yml b/.github/workflows/test-production.yml index 4a55f4803c88..5269358e382a 100644 --- a/.github/workflows/test-production.yml +++ b/.github/workflows/test-production.yml @@ -9,6 +9,7 @@ on: env: NODE_ENV: production + COREPACK_DEFAULT_TO_LATEST: 0 jobs: production: diff --git a/.github/workflows/validate-api-json.yml b/.github/workflows/validate-api-json.yml index 0d254898f8a2..65afcd4cd004 100644 --- a/.github/workflows/validate-api-json.yml +++ b/.github/workflows/validate-api-json.yml @@ -12,6 +12,10 @@ on: paths: - packages/backend/** - .github/workflows/validate-api-json.yml + +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: validate-api-json: runs-on: ubuntu-latest From ad5a940242f6cd65df171301e15b996211bb5a25 Mon Sep 17 00:00:00 2001 From: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> Date: Mon, 3 Feb 2025 11:59:57 +0900 Subject: [PATCH 07/10] fix --- .github/workflows/storybook.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/storybook.yml b/.github/workflows/storybook.yml index f97b9b6d8d8c..be294201f037 100644 --- a/.github/workflows/storybook.yml +++ b/.github/workflows/storybook.yml @@ -13,6 +13,9 @@ on: # This is a waste of chromatic build quota, so we don't run storybook CI on pull requests targets master. - master +env: + COREPACK_DEFAULT_TO_LATEST: 0 + jobs: build: # chromatic is not likely to be available for fork repositories, so we disable for fork repositories. @@ -21,7 +24,6 @@ jobs: env: NODE_OPTIONS: "--max_old_space_size=7168" - COREPACK_DEFAULT_TO_LATEST: 0 steps: - uses: actions/checkout@v4.1.1 From 669fb020d144fc6680656892756f97dbda62660a Mon Sep 17 00:00:00 2001 From: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> Date: Mon, 3 Feb 2025 12:06:26 +0900 Subject: [PATCH 08/10] fix? --- .github/workflows/storybook.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/storybook.yml b/.github/workflows/storybook.yml index be294201f037..e4fcf9d59520 100644 --- a/.github/workflows/storybook.yml +++ b/.github/workflows/storybook.yml @@ -50,7 +50,6 @@ jobs: with: node-version-file: '.node-version' cache: 'pnpm' - - run: corepack enable - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml From a18130e17b469d576b7858285fd6dd40c7d2f2c0 Mon Sep 17 00:00:00 2001 From: anatawa12 Date: Mon, 3 Feb 2025 15:18:04 +0900 Subject: [PATCH 09/10] revert: removing corepack enable --- .github/workflows/storybook.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/storybook.yml b/.github/workflows/storybook.yml index e4fcf9d59520..be294201f037 100644 --- a/.github/workflows/storybook.yml +++ b/.github/workflows/storybook.yml @@ -50,6 +50,7 @@ jobs: with: node-version-file: '.node-version' cache: 'pnpm' + - run: corepack enable - run: pnpm i --frozen-lockfile - name: Check pnpm-lock.yaml run: git diff --exit-code pnpm-lock.yaml From e61dd4906dc13889ccb37482c21e13c257688f73 Mon Sep 17 00:00:00 2001 From: anatawa12 Date: Mon, 3 Feb 2025 15:19:58 +0900 Subject: [PATCH 10/10] test: set COREPACK_DEFAULT_TO_LATEST for federation tests --- packages/backend/test-federation/compose.tpl.yml | 1 + packages/backend/test-federation/compose.yml | 3 +++ 2 files changed, 4 insertions(+) diff --git a/packages/backend/test-federation/compose.tpl.yml b/packages/backend/test-federation/compose.tpl.yml index 8c38f16919f8..8b270e58f7c3 100644 --- a/packages/backend/test-federation/compose.tpl.yml +++ b/packages/backend/test-federation/compose.tpl.yml @@ -17,6 +17,7 @@ services: - ./.config/docker.env environment: - NODE_ENV=production + - COREPACK_DEFAULT_TO_LATEST=0 volumes: - type: bind source: ../../../built diff --git a/packages/backend/test-federation/compose.yml b/packages/backend/test-federation/compose.yml index 62d7e977c04e..a5a7223982ff 100644 --- a/packages/backend/test-federation/compose.yml +++ b/packages/backend/test-federation/compose.yml @@ -25,6 +25,7 @@ services: environment: - NODE_ENV=development - NODE_EXTRA_CA_CERTS=/usr/local/share/ca-certificates/rootCA.crt + - COREPACK_DEFAULT_TO_LATEST=0 volumes: - type: bind source: ../package.json @@ -85,6 +86,8 @@ services: depends_on: redis.test: condition: service_healthy + environment: + - COREPACK_DEFAULT_TO_LATEST=0 volumes: - type: bind source: ../package.json