Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more extra data/parameters #4

Open
jor123 opened this issue Apr 11, 2014 · 1 comment
Open

Support more extra data/parameters #4

jor123 opened this issue Apr 11, 2014 · 1 comment

Comments

@jor123
Copy link
Contributor

jor123 commented Apr 11, 2014

Currently extra_info can be used to add extra parameters. But only SystemInfo is documented as available.

I started creating a CustomDimension class based on the impl of SystemInfo, but I also needed other parameters (session control/override).
I ended up just passing a list of dicts into the extra_info parameter, which works but is kinda 'undocumented API'?
I think the request method should either allow a list 'extra data class instances' (Requestables)? Or document the 'list of dicts' as acceptable input...?

@patrys
Copy link
Contributor

patrys commented Apr 11, 2014

For what it's worth I would rather ditch the SystemInfo part and let you pass a simple dict as extra_info. I don't think it's worth wrapping each and every possible parameter in a separate class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants