Fix broken ui and update readme #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shaders screen should work fine if you're choosing the shaderpack already in a world. |
|
Ah sorry my bad, you are correct. I will see if I can change this PR to either: |
telvarost
changed the title
|
Alright, I changed the PR to fix the bug rather than disable the UI, feel free to re-review :) |
|
I did some testing with the built library and found it didn't apply the shader when not loaded into a world even though it did in the development environment. Therefore, I feel the better solution is to revert the selection when not loaded into a world as the fix does now. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shaders ui is broken and will freeze the game and cause it to flicker.
Readme is outdated, so I copied the info from the discord.
Let me know if anything else needs changed. Thanks!