-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiling #45
Profiling #45
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 70.72% 70.64% -0.08%
==========================================
Files 57 57
Lines 3593 3591 -2
==========================================
- Hits 2541 2537 -4
- Misses 1052 1054 +2 ☔ View full report in Codecov by Sentry. |
Here is some feedback with respect to the notebook structure and the contents of the wandb report.
|
docs/install.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
mkdocs.yml
Outdated
|
||
nav: | ||
- Home: index.md | ||
- Profiling your code: docs/examples/profiling.ipynb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be added in the index.md
file? I imagine that this would add the profiling notebook at the top level of the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: SUMMARY.md (which is the navigation bar), not index.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 7d5c1d2
project/algorithms/example.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
project/configs/algorithm/no_op.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was probably already added in the master
branch
Co-authored-by: Fabrice Normandin <[email protected]>
Co-authored-by: Fabrice Normandin <[email protected]>
Co-authored-by: Fabrice Normandin <[email protected]>
Co-authored-by: Fabrice Normandin <[email protected]>
Co-authored-by: Fabrice Normandin <[email protected]>
Co-authored-by: Fabrice Normandin <[email protected]>
docs/install.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
project/algorithms/example.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already in master?
@@ -39,7 +36,8 @@ | |||
) | |||
def main(dict_config: DictConfig) -> dict: | |||
"""Main entry point for training a model.""" | |||
print_config(dict_config, resolve=False) | |||
# print_config(dict_config, resolve=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd turn this off based on a config value instead of outright removing it
Basic notebook integrated with mkdocks-jupyter. Pushing to test changes on CI.