Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute for FEED_CRYPT_KEY #9

Open
mikelococo opened this issue Aug 12, 2014 · 2 comments
Open

Add attribute for FEED_CRYPT_KEY #9

mikelococo opened this issue Aug 12, 2014 · 2 comments

Comments

@mikelococo
Copy link
Owner

TT-RSS is capable of encrypting (not hashing) passwords used to retrieve authenticated feeds. The default config file has this feature disabled with an empty encryption key. Consider adding an attribute for it.

Need to ponder how to set an initial random one, and what the implications are for an existing site if this value goes from empty-string to something. Does it trigger database encryption? Does it assume the database is already encrypted and break authenticated feeds?

@kaimi
Copy link

kaimi commented Sep 2, 2014

The official OpenSSL cookbook contains a secure_password function you could use.

@mikelococo
Copy link
Owner Author

Thanks for the heads up. I'm not sure getting the random string is particularly the hard part, though. I'm more concerned about existing installs and what will happen to them if I start creating keys by default, which just needs testing to see how tt-rss handles an existing authenticated feed with a empty FEED_CRYPT_KEY, once a new key is set.

As much as I'd like to be secure by default, the first iteration of this is likely to be an empty sting in order to match the default that tt-rss ships. I should also note that I don't use authenticated feeds, so this is relatively low on my personal list... but I wanted the gap documented to hopefully solicit a patch from someone who does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants