Use sync esqlite api instead of stream api to support MacOS #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esqlite author stated[1] that stream functions does not work well with MacOS [1]: mhayashi1120/Emacs-esqlite#2 (comment)
|
Most of the time spent on saving the lyrics with I'm not noticing any real slowdown, either. Can someone who uses MacOS confirm that this PR fixes their problem? (@aladine?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esqlite author stated1 that stream functions does not work well with
MacOS. So I simply replaced those functions with their non-stream
counterparts.
This theoretically makes versuri a bit slower (because it spawns a new
process every time it does a request to DB instead of talking with an
already spawned process) but (at least for my use case) I haven't
experienced any noticeable slowdown. This probably effects the bulk
operations most but I don't use them. Feedback is appreciated on this.
Fixes #3