Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are ports for CMake script libraries acceptable? #9928

Closed
mbeutel opened this issue Feb 5, 2020 · 5 comments
Closed

Are ports for CMake script libraries acceptable? #9928

mbeutel opened this issue Feb 5, 2020 · 5 comments
Assignees
Labels
category:question This issue is a question

Comments

@mbeutel
Copy link
Contributor

mbeutel commented Feb 5, 2020

Would you accept PRs with portfiles for libraries that solely consist of CMake script files?

An example would be YCM. This can be used as a CMake package, i.e. with find_package(YCM), but the config file only modifies CMAKE_MODULE_PATH to make YCM's CMake modules (e.g. InstallBasicPackageFiles) accessible.

I have a Vcpkg port for YCM in my ports repository here:
https://mp-force.ziti.uni-heidelberg.de/asc/infrastructure/vcpkg-ports/blob/master/vcpkg/ports/ycm
I'd be happy to submit a PR with the port.

@mbeutel mbeutel added the category:question This issue is a question label Feb 5, 2020
@traversaro
Copy link
Contributor

Some CMake-only ports already exists in vcpkg, as for example ECM (https://github.com/KDE/extra-cmake-modules), see https://github.com/microsoft/vcpkg/tree/master/ports/ecm and #877 . As ecm was one of the source of inspiration for the creation of YCM , I think it can make sense to have a port for it.

@traversaro
Copy link
Contributor

More related to the YCM port, I would suggest to create it using the offline tarball, otherwise you could make the vcpkg port of ycm vulnerable to any outage in 3rd party repositories, see robotology/ycm-cmake-modules#105 .

@PhoebeHui PhoebeHui assigned PhoebeHui and unassigned ras0219-msft Feb 11, 2020
@PhoebeHui
Copy link
Contributor

@mbeutel, we're happy to accpets the PR, could you please summit a PR this?

@PhoebeHui
Copy link
Contributor

@mbeutel, feel free to summit a PR for this.

@mbeutel
Copy link
Contributor Author

mbeutel commented Mar 5, 2020

Thanks; I just didn't have time yet. Next week, hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:question This issue is a question
Projects
None yet
Development

No branches or pull requests

4 participants