[x264] Build error on arm64-osx

[NeedleCats]

Package: x264[asm,core,gpl]:[email protected]#1

Host Environment

• Host: arm64-osx
• Compiler: Apple clang version 16.0.0
• vcpkg-tool version: 2025-01-11-2025.01.11
• vcpkg-scripts version: c7961da 2025-01-22

To Reproduce

vcpkg install x264

Failure logs

Computing installation plan...
The following packages will be built and installed:
    x264[asm,core,gpl]:[email protected]#1
Detecting compiler hash for triplet arm64-osx...
Compiler found: /Library/Developer/CommandLineTools/usr/bin/c++
Restored 0 package(s) from /Users/marcguo/.cache/vcpkg/archives in 5.08 us. Use --debug to see more details.
Installing 1/1 x264[asm,core,gpl]:[email protected]#1...
Building x264[asm,core,gpl]:[email protected]#1...
-- Using cached videolan-x264-31e19f92f00c7003fa115047ce50978bc98c3a0d.tar.gz.
-- Cleaning sources at /Users/marcguo/vcpkg/buildtrees/x264/src/8bc98c3a0d-84009aba94.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /Users/marcguo/vcpkg/downloads/videolan-x264-31e19f92f00c7003fa115047ce50978bc98c3a0d.tar.gz
-- Applying patch /Users/marcguo/vcpkg/buildtrees/x264/src/version-0.164.3108.diff
-- Applying patch uwp-cflags.patch
-- Applying patch parallel-install.patch
-- Applying patch allow-clang-cl.patch
-- Applying patch configure.patch
-- Using source at /Users/marcguo/vcpkg/buildtrees/x264/src/8bc98c3a0d-84009aba94.clean
-- Found external ninja('1.12.1').
-- Getting CMake variables for arm64-osx
-- Configuring arm64-osx-dbg
CMake Error at installed/arm64-osx/share/vcpkg-make/vcpkg_scripts.cmake:174 (z_vcpkg_set_global_property):
  z_vcpkg_set_global_property Function invoked with incorrect arguments for
  function named: z_vcpkg_set_global_property
Call Stack (most recent call first):
  installed/arm64-osx/share/vcpkg-make/vcpkg_make.cmake:279 (vcpkg_restore_pkgconfig)
  installed/arm64-osx/share/vcpkg-make/vcpkg_make_configure.cmake:108 (vcpkg_make_run_configure)
  ports/x264/portfile.cmake:71 (vcpkg_make_configure)
  scripts/ports.cmake:196 (include)


error: building x264:arm64-osx failed with: BUILD_FAILED
See https://learn.microsoft.com/vcpkg/troubleshoot/build-failures?WT.mc_id=vcpkg_inproduct_cli for more information.
Elapsed time to handle x264:arm64-osx: 4.2 s
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+x264
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?title=[x264]+Build+error+on+arm64-osx&body=Copy+issue+body+from+%2FUsers%2Fmarcguo%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md

[NeedleCats]

I tried installing the same package in an Ubuntu 22.04 Docker container with Vcpkg installed via Linuxbrew, and I got the same errors.

[MonicaLiu0311]

Sorry I didn't repro your issue, you can try #43121 to see if it solves your problem:

Installing 2/2 x264[asm,core,gpl]:[email protected]#1...
Building x264[asm,core,gpl]:[email protected]#1...
Downloading videolan-x264-31e19f92f00c7003fa115047ce50978bc98c3a0d.tar.gz
Successfully downloaded videolan-x264-31e19f92f00c7003fa115047ce50978bc98c3a0d.tar.gz.
-- Extracting source /Users/vcpkg/Monica/vcpkg/downloads/videolan-x264-31e19f92f00c7003fa115047ce50978bc98c3a0d.tar.gz
-- Applying patch /Users/vcpkg/Monica/vcpkg/buildtrees/x264/src/version-0.164.3108.diff
-- Applying patch uwp-cflags.patch
-- Applying patch parallel-install.patch
-- Applying patch allow-clang-cl.patch
-- Applying patch configure.patch
-- Using source at /Users/vcpkg/Monica/vcpkg/buildtrees/x264/src/8bc98c3a0d-84009aba94.clean
-- Found external ninja('1.12.1').
-- Getting CMake variables for arm64-osx
-- Configuring arm64-osx-dbg
-- Configuring arm64-osx-rel
-- Building/Installing arm64-osx-dbg
-- Making target 'all' for arm64-osx-dbg
-- Making target 'install' for arm64-osx-dbg
-- Building/Installing arm64-osx-rel
-- Making target 'all' for arm64-osx-rel
-- Making target 'install' for arm64-osx-rel
-- Fixing pkgconfig file: /Users/vcpkg/Monica/vcpkg/packages/x264_arm64-osx/lib/pkgconfig/x264.pc
-- Fixing pkgconfig file: /Users/vcpkg/Monica/vcpkg/packages/x264_arm64-osx/debug/lib/pkgconfig/x264.pc
-- Installing: /Users/vcpkg/Monica/vcpkg/packages/x264_arm64-osx/share/x264/copyright
-- Performing post-build validation
Stored binaries in 1 destinations in 351 ms.
Elapsed time to handle x264:arm64-osx: 17 s
x264:arm64-osx package ABI: 5b5aaa4a35b4f54324924ccf99785809629b4529a9274ca6961e1a63aa9146b5
Total install time: 19 s
x264 provides pkg-config modules:

  # H.264 (MPEG4 AVC) encoder library
  x264

Similar issues: #43326, #43116.