Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[<vtk[python]>] No python wheel or setup.py generated with VTK_WHEEL_BUILD #43300

Open
hzhshok opened this issue Jan 16, 2025 · 4 comments
Open
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@hzhshok
Copy link

hzhshok commented Jan 16, 2025

Operating system

windows11

Compiler

MSVC

Steps to reproduce the behavior

1. Install vcpkg.
2. Start .\vcpkg.exe install vtk[qt,python,opengl,gdal,geojson,cgns,seacas,sql,proj,netcdf]:x64-windows
3. Delete all installed and packages\vtk_x64-windows\* and buildtrees\vtk\*
4. Edit ports\vtk\portfile.cmake, and add a option: -DVTK_WHEEL_BUILD=ON

# We set all libraries to "system" and explicitly list the ones that should use embedded copies
vcpkg_cmake_configure(
    SOURCE_PATH "${SOURCE_PATH}"
    OPTIONS
        ${FEATURE_OPTIONS}
        ...
        -DCMAKE_FIND_PACKAGE_TARGETS_GLOBAL=ON # Due to Qt6::Platform not being found on Linux platform
	-DVTK_WHEEL_BUILD=ON
5. Build finished

But no setup.py and not generated xxx.whl under installed\x64-windows\tools\python3\Lib or the root installed\x64-windows

Failure logs

It did not have setup.py installed\x64-windows\tools\python3\Lib and not generated xxx.whl under the root path installed\x64-windows.

Regards

Additional context

No response

@hzhshok hzhshok added the category:port-bug The issue is with a library, which is something the port should already support label Jan 16, 2025
@FrankXie05
Copy link
Contributor

@hzhshok Thanks for posting this issue. Can you explain what this option is? -DVTK_WHEEL_BUILD=ON

@FrankXie05 FrankXie05 added requires:more-information This Issue requires more information to solve and removed category:port-bug The issue is with a library, which is something the port should already support labels Jan 16, 2025
@Neumann-A
Copy link
Contributor

vcpkg doesn't build ready do install wheels. (and is also probably not meant for it)

@hzhshok
Copy link
Author

hzhshok commented Jan 20, 2025

@FrankXie05 Thanks for your response!
As what i understand the -DVTK_WHEEL_BUILD=ON is a vtk build option to generate xxx.whl file as vtk guide, and as what i understand, vcpkg has supported and integrated vtk into vcpkg builds, vcpkg should be able to build vtk on all vtk options if no specific description.

You know vcpkg is convinent to build package which supported, so i used vcpkg instead of cmake(to install package manually).

Regards

@FrankXie05
Copy link
Contributor

Thanks for your answer. Just like Neumann-A said #43300 (comment), vcpkg currently does not support VTK_WHEEL_BUILD.

If this option is a file for building guides as you said, we will not integrate the same content about guides or documents. :)

@FrankXie05 FrankXie05 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed requires:more-information This Issue requires more information to solve labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

No branches or pull requests

3 participants