unfocusedAppearance cursorShape doesn't work

[joca-bt]

Windows Terminal version (or Windows build number)

1.8.1444.0

Other Software

No response

Steps to reproduce

settings.json:

{
    ...
    "profiles":
    {
        "defaults":
        {
            ...
            "cursorShape": "filledBox",
            "unfocusedAppearance": {
                "cursorShape": "emptyBox"
            }
        },
        ...
    },
    ...
}

Open Windows Terminal and some other application (e.g. Explorer) and move to that application so that Windows Terminal is unfocused.

Expected Behavior

Cursor changes to empty box.

Actual Behavior

Cursor disappears which makes the setting useless.

[zadjii-msft]

Oh huh. Good point. I wonder what the best way of handling this is. Presumably, if someone has a cursorShape in unfocusedAppearance, then they want the cursor to be visible when the control is unfocused. But I wonder how hard it would be for the Terminal to actually determine we're in that case - IIRC, if there's not a cursorShape in unfocusedAppearance, then we'll silently fall back to the cursor shape in the normal Appearance object.

[DHowett]

I guess we could use the HasCursorShape "inheritance" method!

[zadjii-msft]

But a TermControl only has an IControlAppearance, which doesn't have that method! And I don't feel like bringing Terminal.Settings.Model beneath Terminal.Control

[sdsalyer]

I was surprised this didn't work since it was called out in the release notes for 1.8.1444.0:

A profile can now specify how it will appear when it's not focused via the unfocusedAppearance settings.json key (#8392)

Supported settings: foreground, background, selectionBackground, cursorColor, cursorShape, cursorHeight, backgroundImage, colorScheme, backgroundImageOpacity, backgroundImageStretchMode, backgroundImageAlignment, experimental.retroTerminalEffect, and experimental.pixelShaderPath

I would also point out it seems to work in VS Code, though I haven't changed any settings there other than the theme:

[pwsandoval]

The first comment keeps happening to me, is there a way to fix it?

[mightycoco]

I was looking for this, as well. 1.18.2822.0

[AmerM137]

Same problem here, version 1.21.3231.0.