-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running make docs-prod failing locally #1070
Labels
area/documentation
Improvements or additions to documentation
good first issue
Good for newcomers
scope/S
Change is Small
Comments
kamilprz
added
area/documentation
Improvements or additions to documentation
good first issue
Good for newcomers
scope/S
Change is Small
labels
Nov 26, 2024
Also just noticed that there is a typo in the Makefile:
Should be |
Unable to replicate this today. Successfully able to build and serve: Building
Serving from
|
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 2, 2025
# Description Tiny fix to change a typo from `pod` to `prod`. ## Related Issue [1070](#1070) - originally the issue was for an error in building the docs, but was unable to replicate the issue and marking it as closed. During investigation found this typo. ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. Signed-off-by: Kamil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Improvements or additions to documentation
good first issue
Good for newcomers
scope/S
Change is Small
Describe the bug
Running
make docs-prod
fails when running locally.To Reproduce
Steps to reproduce the behavior:
make docs-prod
Expected behavior
Platform (please complete the following information):
Additional context
Somehow we are still deploying docs to prod though - need to investigate how the pipeline works.
The text was updated successfully, but these errors were encountered: