-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix steps for creating a new app to avoid incompatible versions of react-native
and react-native-windows
being used
#1009
base: main
Are you sure you want to change the base?
Conversation
@@ -26,7 +39,7 @@ Remember to call `@react-native-community/cli init` from the place you want your | |||
<!-- See https://www.npmjs.com/package/react-native?activeTab=versions for the RN version tags. --> | |||
|
|||
```bat | |||
npx --yes @react-native-community/cli@next init <projectName> --version "latest" | |||
npx --yes @react-native-community/cli@next init <projectName> --version "0.77.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "0.77-stable" but Meta hasn't made that tag yet, just pinged them to create it
edit: they'll add the tag manually tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are manually creating a 0.77-stable app here, I'm not sure if you need to add the warning above, the app will always be 0.77-stable (and should be since it's the 0.77 documentation) and not use latest.
|
||
```bat | ||
npm show react-native-windows@latest version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary - we only get out of sync in the delay between the when RN releases a new latest and then we release our matching latest.
Since they don't create a 0.XX-stable until after they release a new latest, we can't rely on that either.
I think that now that we have to use the react-native community CLI, it's easier to just call init with a hat version : ^0.77.0
@@ -26,7 +39,7 @@ Remember to call `@react-native-community/cli init` from the place you want your | |||
<!-- See https://www.npmjs.com/package/react-native?activeTab=versions for the RN version tags. --> | |||
|
|||
```bat | |||
npx --yes @react-native-community/cli@next init <projectName> --version "latest" | |||
npx --yes @react-native-community/cli@next init <projectName> --version "0.77.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npx --yes @react-native-community/cli@next init <projectName> --version "0.77.1" | |
npx --yes @react-native-community/cli@next init <projectName> --version "^0.77.0" |
1dcee53
to
1f4b998
Compare
Description
Fix steps for creating a new app to avoid incompatible versions of
react-native
andreact-native-windows
being usedWhy
Prevents bad experience for new users of RNW.
An issue was hit where using the latest version of
react-native
(0.78) to create an app would lead to it being incompatible with the latest version ofreact-native-windows
. These steps make sure that the user is using a compatible version ofreact-native
for their desired version ofreact-native-windows
.Screenshots
Add any relevant screen captures here from before or after your changes.
Microsoft Reviewers: Open in CodeFlow