Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interfaces to gracefully shutdown external dependencies #23215

Open
dhr-verma opened this issue Nov 26, 2024 · 0 comments
Open

Improve interfaces to gracefully shutdown external dependencies #23215

dhr-verma opened this issue Nov 26, 2024 · 0 comments

Comments

@dhr-verma
Copy link
Contributor

dhr-verma commented Nov 26, 2024

Work Item

Describe the outcome you expect

Currently we are adding support for graceful Redis shutdowns on the server using the PR - #23212.

However, this way of closing connections is not a great design pattern. Instead each resource that uses this dependency should be responsible for disposing all it's external dependencies. Hence, this WI is used to track the changes that will need to be made to redesign interfaces that use external dependencies to have a factory pattern to dispose these resources as well.

Approach

Redesign interfaces using external dependencies to have a .close() or .dispose() method. This will be called while calling the runner's .dispose() method.

Acceptance criteria

Graceful shutdown of external dependencies.

@dhr-verma dhr-verma changed the title Improved interfaces to gracefully shutdown external dependencies Improve interfaces to gracefully shutdown external dependencies Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant