Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Non-Standard 'HttpStatus' Entry for 'HTTP 525 SSL Handshake Failed' Used by Cloudflare #11564

Open
stevenlmcgraw opened this issue Feb 1, 2025 · 0 comments

Comments

@stevenlmcgraw
Copy link

Feature description

Howdy.I searched around previous issues and found some reference to the topic of non-standard HTTP status codes:

However, ^^^these ones are focused on a server returning a non-standard HTTP status code not found in the HttpStatus enum.

This issue looks to focus more on encountering a non-standard HTTP status code from the HttpClient. It looks like things landed on throwing an IllegalArgument exception from HttpStatus::valueOf.

We recently came to realize that Cloudflare employs HTTP 525 SSL Handshake Failed while conducting some disaster testing.

We can definitely go the route of catching the IllegalArgumentException thrown by HttpStatus::valueOf, but I do see a handful of status codes that aren't "official", so to speak, in the HttpStatus enum.

I figured I'd inquire as to the stance Micronaut takes toward extending the HttpStatus enum before setting to work handling the IllegalArgumentException - is it an option to add HTTP 525 SSL Handshake Failed used by Cloudflare?

To me I can understand the answer being "no" and I can understand the answer being "yes"; the reason I thought to ask is because a non-trival volume of Internet traffic transits Cloudflare servers these days, so some of their custom HTTP status codes might be somewhat common in the wild.

If the answer is "yes" I'm happy to add it (or others if there is a desire to cover more of these other custom HTTP status codes I'm seeing can be returned by Cloudflare), if the answer is "no" I'll go about things with the IllegalArgumentException handling - just let know please. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant