diff --git a/projectforge-wicket/src/main/java/org/projectforge/web/user/UserPrefEditForm.java b/projectforge-wicket/src/main/java/org/projectforge/web/user/UserPrefEditForm.java index 475b97c983..22e782f389 100644 --- a/projectforge-wicket/src/main/java/org/projectforge/web/user/UserPrefEditForm.java +++ b/projectforge-wicket/src/main/java/org/projectforge/web/user/UserPrefEditForm.java @@ -235,8 +235,7 @@ void createParameterRepeaterChildren() WicketSupport.get(UserPrefDao.class).updateParameterValueObject(param); if (PFUserDO.class.isAssignableFrom(param.getType()) == true) { final UserSelectPanel userSelectPanel = new UserSelectPanel(fs.newChildId(), - new UserPrefPropertyModel(userPrefDao, - param, "valueAsObject"), + new UserPrefPropertyModel(param, "valueAsObject"), parentPage, param.getParameter()); if (data.getAreaObject() == UserPrefArea.USER_FAVORITE) { userSelectPanel.setShowFavorites(false); @@ -245,8 +244,7 @@ void createParameterRepeaterChildren() userSelectPanel.init(); } else if (TaskDO.class.isAssignableFrom(param.getType()) == true) { final TaskSelectPanel taskSelectPanel = new TaskSelectPanel(fs, - new UserPrefPropertyModel(userPrefDao, param, - "valueAsObject"), + new UserPrefPropertyModel(param, "valueAsObject"), parentPage, param.getParameter()); if (data.getAreaObject() == UserPrefArea.TASK_FAVORITE) { taskSelectPanel.setShowFavorites(false); @@ -255,8 +253,7 @@ void createParameterRepeaterChildren() taskSelectPanel.init(); } else if (GroupDO.class.isAssignableFrom(param.getType()) == true) { final NewGroupSelectPanel groupSelectPanel = new NewGroupSelectPanel(fs.newChildId(), - new UserPrefPropertyModel( - userPrefDao, param, "valueAsObject"), + new UserPrefPropertyModel(param, "valueAsObject"), parentPage, param.getParameter()); fs.add(groupSelectPanel); groupSelectPanel.init(); @@ -286,8 +283,7 @@ protected void setKost2Id(final Long kost2Id) dependentsMap.put(param.getParameter(), kost2DropDownChoice); } else if (ProjektDO.class.isAssignableFrom(param.getType()) == true) { final NewProjektSelectPanel projektSelectPanel = new NewProjektSelectPanel(fs.newChildId(), - new UserPrefPropertyModel( - userPrefDao, param, "valueAsObject"), + new UserPrefPropertyModel(param, "valueAsObject"), parentPage, param.getParameter()); if (data.getAreaObject() == UserPrefArea.PROJEKT_FAVORITE) { projektSelectPanel.setShowFavorites(false); @@ -296,8 +292,7 @@ protected void setKost2Id(final Long kost2Id) projektSelectPanel.init(); } else if (KundeDO.class.isAssignableFrom(param.getType()) == true) { final NewCustomerSelectPanel kundeSelectPanel = new NewCustomerSelectPanel(fs.newChildId(), - new UserPrefPropertyModel( - userPrefDao, param, "valueAsObject"), + new UserPrefPropertyModel(param, "valueAsObject"), null, parentPage, param.getParameter()); if (data.getAreaObject() == UserPrefArea.KUNDE_FAVORITE) { kundeSelectPanel.setShowFavorites(false); @@ -315,7 +310,7 @@ protected void setKost2Id(final Long kost2Id) final LabelValueChoiceRenderer choiceRenderer = new LabelValueChoiceRenderer(this, (I18nEnum[]) param.getType().getEnumConstants()); final DropDownChoice choice = new DropDownChoice(fs.getDropDownChoiceId(), - new UserPrefPropertyModel(userPrefDao, param, "valueAsObject"), choiceRenderer.getValues(), + new UserPrefPropertyModel(param, "valueAsObject"), choiceRenderer.getValues(), choiceRenderer); choice.setNullValid(true); fs.add(choice); @@ -349,15 +344,12 @@ private class UserPrefPropertyModel extends PropertyModel { private static final long serialVersionUID = 6644505091461853375L; - private final UserPrefDao userPrefDao; - private final UserPrefEntryDO userPrefEntry; - public UserPrefPropertyModel(final UserPrefDao userPrefDao, final UserPrefEntryDO userPrefEntry, + public UserPrefPropertyModel(final UserPrefEntryDO userPrefEntry, final String expression) { super(userPrefEntry, expression); - this.userPrefDao = userPrefDao; this.userPrefEntry = userPrefEntry; } @@ -365,7 +357,7 @@ public UserPrefPropertyModel(final UserPrefDao userPrefDao, final UserPrefEntryD public void setObject(final T object) { super.setObject(object); - userPrefDao.setValueObject(userPrefEntry, object); + WicketSupport.get(UserPrefDao.class).setValueObject(userPrefEntry, object); } } }