You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On the current main branch, I feel that operator= of Array_gpu is not implemented correctly. It first sets this->ncells and then checks if this->ncells == 0 to allocate memory if required. However, this well never happens since ncells was just set beforehand:
You are correct. I implemented the view option later and something seem to have gone wrong here. As said before. On the long term we are also open for other array classes if you have better alternatives.
On the current main branch, I feel that
operator=
ofArray_gpu
is not implemented correctly. It first setsthis->ncells
and then checks ifthis->ncells == 0
to allocate memory if required. However, this well never happens sincencells
was just set beforehand:rte-rrtmgp-cpp/include/Array.h
Line 377 in 129363e
I will fix this in a PR once I understand the Array class better.
The text was updated successfully, but these errors were encountered: