Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: func stringInSlice should use EqualsFold #94

Open
riking opened this issue Oct 16, 2019 · 0 comments
Open

nit: func stringInSlice should use EqualsFold #94

riking opened this issue Oct 16, 2019 · 0 comments

Comments

@riking
Copy link

riking commented Oct 16, 2019 •
edited
Loading

https://staticcheck.io/docs/checks#SA6005

In file sanitize.go: if strings.ToLower(straw) == strings.ToLower(needle) { should be strings.EqualsFold(straw, needle)

or, even better, compile a regexp literal for needle and use it for the entire loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@riking