-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Checker Report #228
Comments
Links fixed in 16f1c90 Apart from
Which shouldn't error, so worth checking after the next report |
Lancaster link still errors in #234 Lookup throws this error
The link works though. What should we do here to prevent it failing the link checker @microbit-matt-hillsdon? |
Looks like they haven't failed in more recent runs. There's no retry option, sadly: raviqqe/liche#36 If it's a recurring problem we could implement it, then see if we can get the action updated? There is a timeout option but it's at 30s which seems reasonable. If those specific links fail repeatedly we could add them to the regex ignore. If it's a more general issue with reliability then retries make more sense. It will never be perfect but worth trying to reduce the noise if it's frequent. |
Hmm, though poking around in the HTTP library (fasthttp) that liche uses, it should retry GET requests 5 times by default, which makes the failures a bit more surprising. No backoff is used so far as I can tell. |
I've updated the Mbed link that were causing issues, but the Lancaster article link is persistently failing. I think we should just add it to the regex. What do you think? |
#246 appears to have solved the issue, no report today so closing |
Link Checker
Errors were reported while checking the connectivity of links.
The text was updated successfully, but these errors were encountered: