-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm regex is still valid for non-enum selected envo terms #305
Comments
Check for print out the make squeaky-clean all test
yq '.classes | to_entries | map(select(.value.slot_usage.env_broad_scale)) | from_entries | .[].slot_usage.env_broad_scale.any_of' src/nmdc_submission_schema/schema/nmdc_submission_schema.yaml
yq '.classes | to_entries | map(select(.value.slot_usage.env_broad_scale)) | from_entries | .[].slot_usage.env_broad_scale.pattern' src/nmdc_submission_schema/schema/nmdc_submission_schema.yaml
|
The same pattern is asserted on all of the @mslarae13 can you say more about what makes the regular expression in the
It won't accept
|
That's correct. We currently have no additional validation for pairing and that just is what it is right now until the ontology squad we're kicking off can provide that validation or at least that check. |
The Env Triad squad developed a small selection of terms for submitters to pick their env triad terms for soil, sediment, water and plant.
As part of enabling these enumerations in the submission portal we need to update the submission schema.
However, we should also ensure that the regular expression still works.
Submitters can discover envo terms outside of the provided enum & this is important in our learning what other terms should be included in the enums.
Criteria for completion
The text was updated successfully, but these errors were encountered: