-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to upload an image to NMDC submissions via submission portal #217
Comments
@JamesTessmer let's make this one the next priority :) Please edit my target sprint end date when you have an idea of how long this might take. |
@pkalita-lbl @mslarae13 On the vue side of things neither of these are too hard, so it’s more a matter of what’s going to make sense for the DB. In the LinkML schema we have |
I agree with you here, @JamesTessmer & look forward to @pkalita-lbl 's opinions :) |
This question has come up before on an infrastructure call, but I don't think we came to a consensus. My recollection is that the two main ideas were:
In either case we're not asking users to upload their images to a third-party image hosting site. I think it's still worth having a discussion about these options with the larger development team. IMO 1 may take a little more effort to get set up but may offer better performance and flexibility in the long run. |
Those solutions make sense, and I agree on the third-party sites. That's the biggest reason I liked uploading an actual image more. Either way it at least seems like we would want a component for file input so I can get that working, and maybe we can address this at the 12:30 pm meeting today if there's time for it. |
Blocked: Criteria to unblock: |
/study page of the submission portal should have a "upload image" spot to add a photo of the PI.
The text was updated successfully, but these errors were encountered: