Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PoreWaterInterface class #159

Open
2 tasks
bmeluch opened this issue Oct 3, 2023 · 5 comments
Open
2 tasks

Create PoreWaterInterface class #159

bmeluch opened this issue Oct 3, 2023 · 5 comments
Assignees
Labels
backlog backlogged to be reprioritized in the future

Comments

@bmeluch
Copy link
Contributor

bmeluch commented Oct 3, 2023

Part of microbiomedata/issues#417.

EMSL includes "pore water" as a category for sample submission, which the NMDC submission schema does not support. MIxS does not have a specific "pore water" extension. Maybe a submission schema class can be assembled out of our existing "soil" and "water" slots?

  • Determine slots to be included
  • Add to submission schema files
@bmeluch bmeluch self-assigned this Oct 26, 2023
@bmeluch
Copy link
Contributor Author

bmeluch commented Nov 2, 2023

@mslarae13 based on microbiomedata/issues#417 (comment) should I close this? or mark it as VERY backlogged pending MIxS package?

@turbomam
Copy link
Member

turbomam commented Nov 3, 2023

BTW: if there was going to be some pore_water modeling, wouldn't it be a new slot and not a new class?

@bmeluch
Copy link
Contributor Author

bmeluch commented Nov 7, 2023

If I'm understanding the submission schema correctly (which it is possible that I am not), pore water would be a new sample type which would mean a new submission schema interface class pulling in (mostly) existing schema slots.

@turbomam
Copy link
Member

turbomam commented Nov 9, 2023

Oh, you mean something like PoreWaterInterface, along the same lines as SoilInterface?

Yes, that would be a class. Good point.

@bmeluch bmeluch moved this to 📋 Backlog in UFO SubPort Squad Nov 9, 2023
@mslarae13
Copy link
Contributor

@bmeluch

@mslarae13 based on microbiomedata/issues#417 (comment) should I close this? or mark it as VERY backlogged pending MIxS package?

Yes. Will wait for GSC pore water extension

@mslarae13 mslarae13 added the backlog backlogged to be reprioritized in the future label Jan 4, 2024
@mslarae13 mslarae13 moved this from 📋 Backlog to Cancelled in UFO SubPort Squad Jan 4, 2024
@mslarae13 mslarae13 moved this to 📋 Backlog, Todo in Submission Portal Tracking Apr 17, 2024
@bmeluch bmeluch changed the title Create "pore_water" class Create PoreWaterInterface class Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog backlogged to be reprioritized in the future
Projects
Status: 📋 Backlog, Todo
Status: 🚫 Cancelled
Development

No branches or pull requests

3 participants