Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validate_json-> validate_db_update for real-time ref integ checks #602

Open
PeopleMakeCulture opened this issue Jul 19, 2024 · 3 comments
Assignees

Comments

@PeopleMakeCulture
Copy link
Collaborator

PeopleMakeCulture commented Jul 19, 2024

We are refactoring the util validate_json to be a multi-step process where we:

  • validate_json with Draft7Validator
  • validate_linkml_nmdcdb validates schema with linkML constructor
  • validate_transaction which treats the change set as a db transaction, and checks for referential integrity in the post-update state of the database
@PeopleMakeCulture PeopleMakeCulture converted this from a draft issue Jul 19, 2024
@PeopleMakeCulture PeopleMakeCulture moved this from At bat to On base in Polyneme mixset Jul 28, 2024
@PeopleMakeCulture PeopleMakeCulture moved this from On base to Lineup in Polyneme mixset Jul 28, 2024
@dwinston
Copy link
Collaborator

part of #318

@PeopleMakeCulture PeopleMakeCulture self-assigned this Oct 30, 2024
@PeopleMakeCulture
Copy link
Collaborator Author

On pause until #576 resolved

@PeopleMakeCulture PeopleMakeCulture changed the title Refactor validate_json Refactor validate_json-> 'validate_db_update' for real-time ref integ checks Dec 4, 2024
@PeopleMakeCulture PeopleMakeCulture changed the title Refactor validate_json-> 'validate_db_update' for real-time ref integ checks Refactor validate_json-> validate_db_update for real-time ref integ checks Dec 4, 2024
@eecavanna
Copy link
Collaborator

eecavanna commented Dec 4, 2024

validate_json with Draft7Validator

FYI: In the most recent migration notebook (here), I started using LinkML's Validator class (docs) instead of directly using jsonschema's Draft7Validator class — this was in accordance with guidance from our teammates that work on LinkML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Front of house
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants