Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it support drone 0.8 configuration? #20

Open
sudip-moengage opened this issue Jan 3, 2020 · 1 comment
Open

Does it support drone 0.8 configuration? #20

sudip-moengage opened this issue Jan 3, 2020 · 1 comment

Comments

@sudip-moengage
Copy link

I am migrating from drone enterprise 1.0 to woodpecker (fork of drone 0.8).

My configuration which is written on 1.0 is working fine. But, when I downgrade to 0.8, drone enterprise and woodpecker both running pipeline even if files which required to be changed to trigger builds are not changed.

drone.yml:

pipeline:
  build:
    image: plugins/ecr
    context: ./helm/
    dockerfile: ./helm/Dockerfile
    repo: account.dkr.ecr.us-east-1.amazonaws.com/sre/tiller-ca
    tags:
      - ${DRONE_COMMIT_SHA:0:8}
      - ${DRONE_COMMIT_BRANCH}
      - latest
    when:
      changeset:
        includes: [ helm/** ]

But this 1.0 configuration works for enterprise:

---
kind: pipeline
name: helm

services:
- name: docker
  image: docker:dind
  privileged: true
  volumes:
  - name: dockersock
    path: /var/run

volumes:
- name: dockersock
  temp: {}

steps:
- name: Helm Tiller CA build
  image: docker:dind
  commands:
    - sleep 10
    - docker build ./helm/
  volumes:
    - name: dockersock
      path: /var/run
  when:
    changeset:
      includes: [ helm/** ]
- name: Helm Tiller CA publish
  image: plugins/ecr
  settings:
    context: ./helm/
    dockerfile: ./helm/Dockerfile
    repo: account.dkr.ecr.us-east-1.amazonaws.com/sre/tiller-ca
    registry: account.dkr.ecr.us-east-1.amazonaws.com
    tags:
      - ${DRONE_COMMIT_SHA:0:8}
      - ${DRONE_COMMIT_BRANCH}
      - latest
  when:
    changeset:
      includes: [ helm/** ]

trigger:
  branch: master
  event: [ push ]

Config-changeset-plugin logs:

Processing...
Files changed: [ '.drone.yml', 'README.md' ]
Processing...
Files changed: [ '.drone.yml', 'README.md' ]
@microadam
Copy link
Owner

Hello,

This has only ever been tested on drone 1.0+. It seems that it doesn't work on 0.8 at present from your testing. I have no plans to add support for 0.8, but if you are able to make it backwards compatible, then I would be happy to accept a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants