Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return 204 no-content if yaml not mutated #14

Open
bradrydzewski opened this issue Oct 8, 2019 · 1 comment
Open

return 204 no-content if yaml not mutated #14

bradrydzewski opened this issue Oct 8, 2019 · 1 comment

Comments

@bradrydzewski
Copy link

I recommend returning a 204 no content if the yaml is not mutated (no changeset attributes defined, etc). The reason is that when no content is returned, Drone will fallback to the default fetch logic. This is important for installations that are still using 0.8 configuration files, since the default logic will handle conversion.

(PS sorry for not being more proactive with a pull request, but the Drone backlog is keeping me too busy right now)

@microadam
Copy link
Owner

Good to know! I will add that in when I have some time. Should be a fairly simple change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants