Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmm scan node error #695

Closed
1 task done
treymur opened this issue Oct 7, 2024 · 7 comments · Fixed by #696 · May be fixed by #766
Closed
1 task done

mmm scan node error #695

treymur opened this issue Oct 7, 2024 · 7 comments · Fixed by #696 · May be fixed by #766
Labels
bug Something isn't working released

Comments

@treymur
Copy link

treymur commented Oct 7, 2024

What happened?

I tried to run scan and got a node error. Same error with both 2.0.5 and 2.0.4.
image

What did you expect to happen?

I expected it to scan for mods in my mods folder

Which command did you run?

mmm scan

Operating System

Linux

What version of MMM are you running?

2.0.5

Contents of the modlist.json

{
  "loader": "fabric",
  "gameVersion": "1.21.1",
  "defaultAllowedReleaseTypes": [],
  "modsFolder": "./mods",
  "mods": []
}

Contents of the modlist-lock.json

[]

I have updated

  • I swear I have tried it with the latest version!
@treymur treymur added the bug Something isn't working label Oct 7, 2024
@meza
Copy link
Owner

meza commented Oct 7, 2024

Ooh, I've seen this before! Let me see if I can replicate it. If not, I might need a zip of your mods folder

@meza meza linked a pull request Oct 8, 2024 that will close this issue
fix: undefined name #696
Merged
@meza meza closed this as completed in #696 Oct 8, 2024
@meza
Copy link
Owner

meza commented Oct 8, 2024

Should be fixed in the new release: https://github.com/meza/minecraft-mod-manager/releases/tag/v2.0.6

Thanks for reporting it ^^

@meza meza added the released label Oct 8, 2024
@muluffel
Copy link

muluffel commented Dec 1, 2024 •
edited
Loading

I have run mmm scan (on Windows) in version 2.0.6 and also get the error. But still I have the output above that some unmanaged mods were found. Any ideas? Layer 8 in that case?
It also didn't add the mods it outputted to the modlist using --add
image

Should I open a new issue?

@meza
Copy link
Owner

meza commented Dec 2, 2024

Hmm, this is a persistent one isn't it... What's your modlist?

@muluffel
Copy link

muluffel commented Dec 3, 2024 •
edited
Loading

Well, the modlist is pretty empty cause it won't put in my mods, but that's its contents:

  "loader": "fabric",
  "gameVersion": "1.21",
  "defaultAllowedReleaseTypes": [
    "alpha",
    "beta",
    "release"
  ],
  "modsFolder": "C:\\Users\\Max\\AppData\\Roaming\\.minecraft\\mods",
  "mods": []
}

Do you want to know my installed mods? I can send you a screenie on dc

@meza meza reopened this Dec 16, 2024
meza added a commit that referenced this issue Dec 16, 2024
@meza
Fix scan command error handling
04126d3 
fix: attempting to fix #695
@meza meza mentioned this issue Dec 16, 2024
Open
@morgantic
Copy link

Can confirm that this still happens in v2.0.6

meza added a commit that referenced this issue Jan 12, 2025
@meza
fix: potential fix for #695 #751 #767
f28661d
@meza
Copy link
Owner

meza commented Jan 13, 2025

Closing in hopes of 2.0.7 fixing it. Please reopen if not

@meza meza closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
4 participants
@meza @muluffel @morgantic @treymur