Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install mod's dependencies #203

Open
tennox opened this issue Jan 23, 2023 · 2 comments
Open

Install mod's dependencies #203

tennox opened this issue Jan 23, 2023 · 2 comments
Labels
feature A new feature to add good first issue Good for newcomers planned This feature is planned to be developed
Milestone

Comments

@tennox
Copy link

tennox commented Jan 23, 2023

I love the lockfile approach this cli takes (as opposed to profiles in ferium), but it doesn't seem to install the required mods as listed in the mod manifest, for example:
image

But running mmm add H3LWVGe4 doesn't install any dependencies:
image

mmm --version
1.1.1

@meza
Copy link
Owner

meza commented Jan 23, 2023

Thanks for bringing this up!
No, the mod manager doesn't do anything magic. If you require a mod as a dependency, you need to add it manually. It's the only way to make sure it works in a consistent way no matter the platform you use (curseforge, modrnith or anything in the future).

I'll look into this more but I can't promise anything for the time being.

@meza meza added feature A new feature to add under consideration planned This feature is planned to be developed and removed under consideration labels Jan 23, 2023
@meza meza added this to the 1.3.0 milestone Jan 23, 2023
@meza
Copy link
Owner

meza commented Jan 23, 2023

Ok, I think there is a way to make this work in a very simplistic way - maybe.

The question is, what happens when 2 mods depend on different versions of the same mod?

I think the tier0 solution will be to just have mmm abort and ask the user to figure things out manually. In such a situation you wouldn't be able to use both mods anyway, so it should just be an unfortunate edge case. Right?

Keep an eye on this space. Should drop in version v1.3.0 eventually.

@meza meza moved this to Todo in Minecraft Mod Manager Jan 26, 2023
@meza meza added the good first issue Good for newcomers label Jan 27, 2023
@meza meza removed this from the 1.3.0 milestone Dec 21, 2023
@meza meza modified the milestone: 2.0.0 Jul 31, 2024
@meza meza added this to the 3.0.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature to add good first issue Good for newcomers planned This feature is planned to be developed
Projects
Status: Todo
Development

No branches or pull requests

2 participants