Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring metrics to order, fix typos, add <recType, Metric> signature #156

Open
maxfilippov opened this issue Apr 3, 2020 · 3 comments · Fixed by #161
Open

bring metrics to order, fix typos, add <recType, Metric> signature #156

maxfilippov opened this issue Apr 3, 2020 · 3 comments · Fixed by #161
Assignees
Labels
in work issue is worked on refactoring

Comments

@maxfilippov
Copy link
Collaborator

No description provided.

@maxfilippov maxfilippov self-assigned this Apr 3, 2020
@maxfilippov maxfilippov changed the title Update: VOI functor: add <recType, Netric> signature Update: VOI functor: add <recType, Metric> signature Apr 3, 2020
@maxfilippov maxfilippov changed the title Update: VOI functor: add <recType, Metric> signature bring metrics to order, fix typos, add <recType, Metric> signature Apr 6, 2020
@maxfilippov
Copy link
Collaborator Author

maxfilippov commented Apr 6, 2020

  • fix typos in metric names and params
  • update Entropy & VOI with <Metric, RecType> signature,
  • add global utils.hpp with type converters, update algorithms that depeng on it (ESN, PCFA, DSPCC) to make them use the common code
  • update Entropy & VOI to make it support Blaze vector input
  • update inner and output value type of all metrics to double

@maxfilippov maxfilippov linked a pull request Apr 6, 2020 that will close this issue
@maxfilippov maxfilippov reopened this Apr 7, 2020
@maxfilippov
Copy link
Collaborator Author

continuing after rename merged..

@maxfilippov
Copy link
Collaborator Author

maxfilippov commented Feb 8, 2021

there are multiple issues and branches related to the general refactoring:

The main discussion about API changes is in #180 (branch https://github.com/panda-official/metric/tree/framework_design, started only for discussion, not to be merged)

Also there are branches
https://github.com/panda-official/metric/commits/refactored (newer)
and
https://github.com/panda-official/metric/commits/refactored_jura (older, with some already changes moved to the refactored branch)
, where some breaking changes are implemented. Continuing with these branches will change the API and needs changes to client caller code. Also, since the work was paused, both of them may be outdated.

Also there are old issues related to the general refactoring task:
#21 (unify the API of distance functions and factory functions in distance module. #21) - distance functions/functors is what the refactoring begins from
#32 (make all functions work with blaze container inputs. #32) - also can be considered as a subtask of the refactoring
#29 (update Wavelet API #29) - particular task for wavelet module also covered by general refactoring

I think we can unite these issues into one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in work issue is worked on refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants