From 068e39b80b072a1e273c5af2fff50632870cf4ab Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Sat, 5 Dec 2020 13:02:32 -0800 Subject: [PATCH] Prune events (#8) * feat: remove mouse, keydown events from Toggle * chore: formatting * chore: update docs --- README.md | 4 ---- src/Toggle.svelte | 6 +----- test.svelte | 11 ++++++++++- types/Toggle.d.ts | 4 ---- 4 files changed, 11 insertions(+), 14 deletions(-) diff --git a/README.md b/README.md index 93c3cff..e97ebca 100644 --- a/README.md +++ b/README.md @@ -138,12 +138,8 @@ The `Toggle` component dispatches a "toggle" event. ## Forwarded events - on:click -- on:mouseover -- on:mouseenter -- on:mouseout - on:focus - on:blur -- on:keydown ## TypeScript diff --git a/src/Toggle.svelte b/src/Toggle.svelte index 101357c..585ad2b 100644 --- a/src/Toggle.svelte +++ b/src/Toggle.svelte @@ -134,12 +134,8 @@ {disabled} on:click on:click={() => (toggled = !toggled)} - on:mouseover - on:mouseenter - on:mouseout on:focus - on:blur - on:keydown /> + on:blur /> {#if on && off}{toggled ? on : off}{/if} diff --git a/test.svelte b/test.svelte index 10f51f2..1429f3e 100644 --- a/test.svelte +++ b/test.svelte @@ -10,7 +10,16 @@ on="On" off="Off" on:toggle={(e) => { - console.log(e.detail); + console.log(e.detail); // boolean + }} + on:click={(e) => { + console.log(e); // MouseEvent + }} + on:focus={(e) => { + console.log(e); // FocusEvent + }} + on:blur={(e) => { + console.log(e); // FocusEvent }} /> diff --git a/types/Toggle.d.ts b/types/Toggle.d.ts index 7825121..434e4b2 100644 --- a/types/Toggle.d.ts +++ b/types/Toggle.d.ts @@ -59,12 +59,8 @@ export default class Toggle extends SvelteComponentTyped< { toggle: CustomEvent; click: WindowEventMap["click"]; - mouseover: WindowEventMap["mouseover"]; - mouseenter: WindowEventMap["mouseenter"]; - mouseout: WindowEventMap["mouseout"]; focus: WindowEventMap["focus"]; blur: WindowEventMap["blur"]; - keydown: WindowEventMap["keydown"]; }, { default: { toggled: boolean } } > {}