Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Changes Made to global.js #26

Open
tzhbami7 opened this issue Dec 22, 2017 · 6 comments
Open

Apply Changes Made to global.js #26

tzhbami7 opened this issue Dec 22, 2017 · 6 comments

Comments

@tzhbami7
Copy link

tzhbami7 commented Dec 22, 2017

Hi there,

I've deployed nodejs-pool && poolui successfully a couple of days ago with following install script

https://github.com/Snipa22/nodejs-pool/blob/master/deployment/deploy.bash#L51

When I do some changes to my pool name in ~/poolui/build/globals.js, I cannot see the new changes on the webpage after refreshing the browser or after doing service caddy restart. It seems to only take effect if I reboot the server.

There is a closed issue about this on the issue tracker from nodejs-pool which suggests to change the checksum on app.manifest which unfortunately doesn't work for me :/
Snipa22/nodejs-pool#78

What is the correct way to apply the changes made to global.js?

Thanks for the support!

@miziel
Copy link

miziel commented Dec 22, 2017

It's browser caching imo, nothing else... Deleting the web application cache manually worked for me.
In theory changing app.manifest should force browser to re-download the files but...

@tzhbami7
Copy link
Author

thx for the hint - You're awesome :) Worked like a charm after deleting app cache on the browser.
I thought the web server would serve some cached html files :/

Just one thing left on the error list. I just saw on the chrome dev console that I'm receiving

Application Cache Progress event (56 of 83) http://domain.xx/assets/sponsor-logo.png /#/home:1 Application Cache Progress event (57 of 83) http://domain.xx/user/blocks/blocks.js /#/home:1 Application Cache Progress event (58 of 83) http://domain.xx/index.html /#/home:1 Application Cache Error event: Resource fetch failed (4) http://domain.xx/index.html
DOMException: Failed to execute 'update' on 'ApplicationCache': there is no application cache to update.

Is this maybe the reason why I have to delete the cache by hand each time on updating content?

@miziel
Copy link

miziel commented Dec 22, 2017

Yes, seems like it. The original ui is unfortunately a bit crude and unfinished... But after some tweaking it is usable.

@tzhbami7
Copy link
Author

ok then. I will further investigate and put my results here for the record.

@BKdilse
Copy link

BKdilse commented Mar 15, 2018

I've had this issue for ages, and deleting the cache on a mobile appears to work, but its a pain.
In Chrome Desktop, CTRL-F5 works fine.

@tzhbami7 did you get any further in working out how we can get around this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@tzhbami7 @miziel @BKdilse and others