Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ sign inside strings break parsing #6195

Closed
knsv opened this issue Jan 17, 2025 · 0 comments · Fixed by #6196
Closed

@ sign inside strings break parsing #6195

knsv opened this issue Jan 17, 2025 · 0 comments · Fixed by #6196
Assignees
@knsv
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@knsv
Copy link
Collaborator

knsv commented Jan 17, 2025

Description

This code should not generate syntax error:

      flowchart LR
        AB["apa@apa@"] --> B(("`apa@apa`"))

The issue was introduced with the addition of ids for edges (still not released).

Steps to reproduce

...

Screenshots

No response

Code Sample

Setup

  • Mermaid version:
  • Browser and Version: [Chrome, Edge, Firefox]

Suggested Solutions

No response

Additional Context

No response
@knsv knsv added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Jan 17, 2025
@knsv knsv self-assigned this Jan 17, 2025
knsv added a commit that referenced this issue Jan 17, 2025
@knsv
#6195 Updated lexer to not allow quotes in link ids
9a90d79
@knsv knsv mentioned this issue Jan 17, 2025
Merged
4 tasks
ashishjain0512 added a commit that referenced this issue Jan 21, 2025
@ashishjain0512
Merge pull request #6196 from mermaid-js/6195-at-signs-in-labels
84b03f3 
#6195 at signs in labels
@sourcery-ai sourcery-ai bot mentioned this issue Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knsv knsv

Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6195 at signs in labels mermaid-js/mermaid
1 participant
@knsv