Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis HealthCheck - "FIXME" #44

Open
Better-Boy opened this issue Oct 19, 2020 · 2 comments
Open

Redis HealthCheck - "FIXME" #44

Better-Boy opened this issue Oct 19, 2020 · 2 comments

Comments

@Better-Boy
Copy link

Which service(s) is this report about?
Let us know which services(s) this report is about:

  • Alegre

Description:
# FIXME Redis database is not being tested by info() - https://github.com/meedan/alegre/blob/develop/app/main/controller/healthcheck_controller.py#L44

Currently, in health check in redis, more than needed information is fetched from the redis using r.info() which is not used anywhere in the healthcheck code.
@Better-Boy
Copy link
Author

Better-Boy commented Oct 19, 2020 •
edited
Loading

I have fixed this with explanation in the PR meedan/alegre#36

@Better-Boy
Copy link
Author

Better-Boy commented Nov 1, 2020 •
edited
Loading

@computermacgyver This issue is fixed with the PR merged yesterday in the alegre repository. Can this issue be closed with the tags hacktoberfest and the component as alegre?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Better-Boy