Replace inline stylings with Material-UI Box attributes #748
Conversation
There was a problem hiding this comment.
Thanks @amaaniqbal for your contribution! We appreciate it! Please notice that it won't work if you don't import material-ui Box on those files! Please fix as needed so we are able to accept it! Thanks again for contributing!
|
Oops, missed it! Fixing it right away... |
There was a problem hiding this comment.
Hello @amaaniqbal ! Thank you so much for your interest in contributing! Please notice that some coding standards need to be met and we require a few changes to accept this PR. I kindly ask you to review your PR and apply these changes. Mainly the string props should be enclosed in double quotes, and unused imports should be removed.
|
@amoedoamorim I did the suggested changes. Please have a look! |
|
Thanks @amaaniqbal for your contribution! We appreciate it! There are a couple of conflicts in your PR in relation to current |
|
Fixed the conflicts @amoedoamorim! |
|
Hello @amaaniqbal ! Thanks for your contribution! We appreciate it! Your PR looks good in general, but there are some conflicts resulting from merges of PRs from others. Please solve those so we can go ahead and merge yours! |
|
Fixed the merge conflicts again @amoedoamorim! |
|
Hello @amaaniqbal, I was away for the past weeks and was unable to merge your PR. Would you please fix this conflict so I can merge your PR? Thank you! |
|
Hello @alexmeedan, this PR was up since Hacketoberfest and since then I am just resolving merge conflicts. I resolved them once again, but please review this before merging any other PRs this time if possible. Also, please consider this as a part of Hacktoberfest. PS: |
|
Yes, I'll merge as soon as it's fixed! I couldn't do it before because your previous commit was sent in while I was away. It will still count for Hacktoberfest and eligible for Meedan swag. I apologize for the inconvenience. The file |
|
Thanks a lot for the positive response @alexmeedan! I removed the unused file |
|
Hello @amaaniqbal . I did some fixing, merging and cleaning up myself and merged your contribution on another branch. Thanks again for participating in Hacktoberfest with Meedan! We appreciate your contribution! |
|
Thanks a lot for merging my changes @amoedoamorim! I can see them in the PR over here. May I know what made my previous commits fail Travis build and your commit passed? |
This PR replaces inline stylings present in
tag/andteam/directories insidecheck-web/src/app/components/with the corresponding Material-UIBoxcomponent attributes.Fixes #18