Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not_zero_canonical #18

Open
smoreira00 opened this issue May 31, 2023 · 5 comments
Open

not_zero_canonical #18

smoreira00 opened this issue May 31, 2023 · 5 comments

Comments

@smoreira00
Copy link

What does exactly this 'not_zero_canonical' parameter do? In which situations do I have to set it to True/False?

@yuehaowang
Copy link
Collaborator

When not_zero_canonical is set to False, the canonical frame is set to the first frame (t=0), i.e., all the displacements of the first frame are set to zeros. When set to True, the canonical frame is not explicitly specified.

Please refer to the related code:

if cur_time == 0. and self.zero_canonical:
dx = torch.zeros_like(input_pts[:, :3])

In general, this hyperparameter only affects the rendering/reconstruction of the first frame.

@smoreira00
Copy link
Author

smoreira00 commented Jun 20, 2023

So when we set not_zero_canonical to True, does the EndoNeRF randomly chooses a frame to set as the canonical frame? Or it doesn't set any frame as the canonical one?

@yuehaowang
Copy link
Collaborator

When not_zero_canonical is set to True, the model does not take any frame as the canonical space but just predicts displacement fields (generally non-zero) for each frame.

@smoreira00
Copy link
Author

And when not_zero_canonical=False, why does the rendering/reconstruction of the first frame get so affected?

@yuehaowang
Copy link
Collaborator

This is because the canonical field is supposed to contain all the appeared areas in the whole video. Since there is no strong regularization of the predicted displacements, those new areas in the live frame might be remapped to random locations in the canonical field, resulting in some artifacts in the first frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants