Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getDirectory() and other assorted changes related to OPFS #22738

Merged

Conversation

chrisdavidmills
Copy link
Contributor

Description

Chrome 109 sees the Origin Private File System features of the File System API enabled in Chrome Android and WebView. This PR makes some changes related to those updates. Most notably:

  • I've broken out the details of the OPFS into its own section on the main File System Access API landing page. Any mentions of the OPFS on other pages now link to this section rather than the spec.
  • I've added a page for StorageManager.getDirectory(), as it was missing before.

See my research document for more details on the changes made: https://docs.google.com/document/d/1rPYCw13kIrTnSvUaStCoDFTyeYHXy7tgykiumnccGTI/edit#

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested review from a team as code owners December 5, 2022 12:02
@chrisdavidmills chrisdavidmills requested review from sideshowbarker and bsmth and removed request for a team December 5, 2022 12:02
@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

@chrisdavidmills chrisdavidmills marked this pull request as draft December 5, 2022 12:55
@a-sully
Copy link

a-sully commented Dec 6, 2022

Mostly LGTM!

@chrisdavidmills chrisdavidmills marked this pull request as ready for review December 7, 2022 08:21
@a-sully
Copy link

a-sully commented Dec 7, 2022

I don't have permission to actually approve this change, but LGTM! 👍

@chrisdavidmills
Copy link
Contributor Author

@a-sully no worries; thanks a lot for the tech review!

@sideshowbarker sideshowbarker merged commit ce50e88 into mdn:main Dec 8, 2022
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request Dec 12, 2022
@chrisdavidmills chrisdavidmills deleted the opfs-changes-file-system-access-api branch December 12, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants