-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add getDirectory() and other assorted changes related to OPFS #22738
Merged
sideshowbarker
merged 4 commits into
mdn:main
from
chrisdavidmills:opfs-changes-file-system-access-api
Dec 8, 2022
Merged
add getDirectory() and other assorted changes related to OPFS #22738
sideshowbarker
merged 4 commits into
mdn:main
from
chrisdavidmills:opfs-changes-file-system-access-api
Dec 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdavidmills
requested review from
sideshowbarker and
bsmth
and removed request for
a team
December 5, 2022 12:02
a-sully
reviewed
Dec 6, 2022
a-sully
reviewed
Dec 6, 2022
Mostly LGTM! |
I don't have permission to actually approve this change, but LGTM! 👍 |
@a-sully no worries; thanks a lot for the tech review! |
sideshowbarker
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chrome 109 sees the Origin Private File System features of the File System API enabled in Chrome Android and WebView. This PR makes some changes related to those updates. Most notably:
StorageManager.getDirectory()
, as it was missing before.See my research document for more details on the changes made: https://docs.google.com/document/d/1rPYCw13kIrTnSvUaStCoDFTyeYHXy7tgykiumnccGTI/edit#
Motivation
Additional details
Related issues and pull requests