Move Arduino code to platformIO based projects

[moritz89]

The reason's I would be interested in moving to PlatformIO projects is:

• Automated dependency management
• Good continuous integration support

Other reasons include:

• Code completion/syntax checking
• C++ compiler instead of INO pre-compiler
  • Forces Object Oriented programming
• Improved search functionality
• Split-screen editor
• Improved multi-platform support

I have already converted the hapifirmware source code to the PlatformIO format so that it can be tested. Installation instructions can be found in the folder itself.

[ozarchie]

I have no problem with platform io. I use it for other projects and agree with your comments

[PedroSFreitas]

@TylerReedMC I think we should add @ozarchie as member, so if needed we could tag his as reviewer.

[PedroSFreitas]

@moritz89 I'm not familiar with PlatformIO, but nothing that I can get in a few days. Looks very good. And if @ozarchie approved I'm on board too.

[ozarchie]

The arduino code was stable, and I can compare and test the revised PlatformIO on my system. Although I prefer more modular than monolithic block approach to the code, I will leave the PlatformIO code as you have coded.

The final issues really related to integration with the Python code.
While the nodes were able to send and respond to the MQTT data, the integration, control from and use of that data by the Python code was were the last issues lay. Once you are ready, I can help with that testing, if you wish. I have a multitude of sensors, ESP8266 as well as ESP32 based systems, and TI-bluetooth connected sensors as well.
Happy coding,
Cheers, Archie

[moritz89]

@ozarchie Just to avoid confusion, the code in the hapifirmware folder is not equivalent to the one in hapinode. These seemed to be two different code bases, with hapifirmware being significantly smaller functionality wise. Is there a reason for the split between hapifirmware and hapinode?

What I did was move the code in hapifirmware/hapifirmware.ino to hapifirmware/src/main.cpp: git diff b693e3f..30bd4bb --stat -- src/dumb_module/arduino/`. I started moving the hapinode code, but it will require quite a bit of refactoring. Therefore, low priority and working on it iteratively (check the make_dumb_module_oo branch).

[ozarchie]

The hapifirmware codebase is based on an early implementation of the system, using a proprietary protocol and usb connection. The hapinode code was developed for mqtt and wireless.

[moritz89]

Cool and good to know 🙂