Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate approval with an auto-approve option #2

Open
maxbechtold opened this issue Nov 25, 2017 · 3 comments
Open

Accelerate approval with an auto-approve option #2

maxbechtold opened this issue Nov 25, 2017 · 3 comments

Comments

@maxbechtold
Copy link
Owner

Right now, the user has to manually overwrite the current master files in order to approve a new set of master files (or execute the created approval script)

It would be better to have this closer to the test execution, i.e. perform the approval as part of a test execution.

@maxbechtold
Copy link
Owner Author

maxbechtold commented Nov 25, 2017

Also, the user is forced to run the tests twice in order to 1) create and 2) approve the master files approved. Could this be done in a single step?

This is followed up in #6.

@maxbechtold
Copy link
Owner Author

maxbechtold commented Jan 21, 2018

It can also be useful to test if different ways of running a program result in the same outcome. Support for this is developed in the branch https://github.com/maxbechtold/golden-master/tree/approval-id. (merged into master.)

@maxbechtold
Copy link
Owner Author

It would be better to have this closer to the test execution, i.e. perform the approval as part of a test execution.

I'm not seeing a way to achieve this without any user action. However, a system property like -Dmaxbe.golden-master.approve=true when running the Golden Master tests could be used to auto-approve the output even without them matching the master files. In order to avoid accidental overwriting of the master files, the tests should probably not "succeed" (but instead abort.)

maxbechtold added a commit that referenced this issue Feb 15, 2018
maxbechtold added a commit that referenced this issue Feb 15, 2018
@maxbechtold maxbechtold changed the title Devise a workflow of approval Accelerate approval with an auto-approve option Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant