Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] Deal with whether actions are allowed at compliation time, not evaluation time #1031

Open
LeaVerou opened this issue Jul 31, 2024 · 0 comments
Labels
Effort: medium Priority: low Refactor Code improvements Status: 4. Ready to implement We know how to implement this, but who will do it? Topic: Actions

Comments

@LeaVerou
Copy link
Member

Currently we check if we're in an Actions context every single time an identifier is resolved: https://github.com/mavoweb/mavo/blob/main/src/mavoscript.js#L9

And use this awkward hack for that:

Mavo.Actions._running = Mavo.Actions.running;

But why? All we need to do is pass to the compiler that we're in an actions context and compile the function differently in that case.

@LeaVerou LeaVerou added Effort: medium Priority: low Refactor Code improvements Status: 4. Ready to implement We know how to implement this, but who will do it? Topic: Actions labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: medium Priority: low Refactor Code improvements Status: 4. Ready to implement We know how to implement this, but who will do it? Topic: Actions
Projects
None yet
Development

No branches or pull requests

1 participant