Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using reply.res results in a FastifyDeprecation message #2

Open
kmai opened this issue Apr 22, 2021 · 2 comments · Fixed by #3
Open

Using reply.res results in a FastifyDeprecation message #2

kmai opened this issue Apr 22, 2021 · 2 comments · Fixed by #3

Comments

@kmai
Copy link
Contributor

kmai commented Apr 22, 2021

Using fastify 3.14.0 and fastify-jaeger 1.0.1 in Node 14 results in a FastifyDeprecation message:

(node:19) [FSTDEP002] FastifyDeprecation: You are accessing the Node.js core response object via "reply.res", Use "reply.raw" instead.
@kmai kmai mentioned this issue Apr 22, 2021
Merged
@maumercado maumercado reopened this May 7, 2021
@maumercado
Copy link
Owner

This change breaks nodejs 10

@maumercado
Copy link
Owner

maumercado commented May 7, 2021 •
edited
Loading

Need to update the plugin to use Fastify 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace reply.res.statusCode with reply.statusCode kmai/fastify-jaeger
2 participants
@maumercado @kmai