Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot is sending illegal html attributes #63

Open
krille-chan opened this issue Apr 5, 2022 · 1 comment
Open

Bot is sending illegal html attributes #63

krille-chan opened this issue Apr 5, 2022 · 1 comment

Comments

@krille-chan
Copy link

In the Matrix spec it is very hard specified which HTML tags and attributes are allowed in formatted messages. When using the native setInnerHtml method with a node validator in a browser, it complains a lot in the logs which afaik can't be muted:

Removing disallowed attribute <SPAN title="Issues relevant to the frontend team"> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <SPAN title="This issue is intended to be the place for an open discussion about a specific topic."> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <STRONG data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> 2 [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <STRONG data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> 2 [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <STRONG data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> 2 [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <STRONG data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> 2 [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <STRONG data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> 4 [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <STRONG data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> 2 [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <STRONG data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <SPAN title="Issues that are actionable / can be picked up for work"> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <SPAN title="In progress"> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <STRONG data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> 2 [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <STRONG data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <SPAN title="Issues relevant to the frontend team"> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <SPAN title="This issue is intended to be the place for an open discussion about a specific topic."> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <STRONG data-mautrix-exclude-plaintext=""> [main.dart.js:12596:47](https://famedly.gitlab.io/company/frontend/famedly-web/main.dart.js)
Removing disallowed attribute <A data-mautrix-exclude-plaintext="">

Is there an alternative for using "title" or "data-*" attributes?

@tulir
Copy link
Member

tulir commented Apr 5, 2022

The Matrix spec doesn't have any hard specification on which HTML tags and attributes are allowed, it only has a recommendation for what to allow when rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants