Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cost currency to load dynamically from the user's Pod Point account #23

Open
mattrayner opened this issue Jan 22, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mattrayner
Copy link
Owner

Is your feature request related to a problem? Please describe.
I would like to automatically define the currency of our cost sensors based on the return from Pod Point rather than defaulting to GBP and allowing the user to set it.

Its un-necessary logic in the integration and should be cleaned up

Describe the solution you'd like
Looking at the user data returned from podpointclient, we should use the attributes returned from the Pod Point APIs to drive the currency data in PodPointTotalCostSensor and it's children

Describe alternatives you've considered
N/A

Additional context
This has become possible thanks to the changes in podpointclient

@mattrayner mattrayner added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant