New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming `LIBMEXCLASS_EXTERNAL_PROJECT_TARGET_NAME` in example to disambiguate from the imported libmexclass target. #25

Open

sreeharihegden opened this issue Jan 26, 2023 · 0 comments

Labels

todo

Member

sreeharihegden commented Jan 26, 2023

In the libmexclass/example/CMakeLists.txt, the target LIBMEXCLASS_EXTERNAL_PROJECT_TARGET_NAME is set to libmexclass.

Consider renaming this target to disambiguate from the imported libmexclass target.

The text was updated successfully, but these errors were encountered:

sreeharihegden added the todo label

sreeharihegden added a commit that referenced this issue


          Fix for Issue #34: Update gateway() calls to use packaged name. Also …

fd8ff16

…fixes Issues #25, #28.

sreeharihegden added a commit that referenced this issue


          Revert "Fix for Issue #34: Update gateway() calls to use packaged nam…

f384ee8

…e. Also fixes Issues #25, #28."

Will resubmit on top of Kevin's latest changes for Issue #32: Refactor libmexclass.proxy.Proxy.

This reverts commit fd8ff16.

sreeharihegden added a commit that referenced this issue


          Fix for Issue #34: Update gateway() calls to use packaged name.

618187c

Also fixes Issues #25, #28.

sreeharihegden added a commit that referenced this issue


          Move libmexclass install steps to ExternalProject_Add INSTALL_COMMAND.

549ba39

Also revert previous fix for Issue #25.

sreeharihegden added a commit that referenced this issue


          Fix for Issue #34: Update gateway() calls to use packaged name.

20252bb

Also fixes Issues #25, #28.

sreeharihegden added a commit that referenced this issue


          Move libmexclass install steps to ExternalProject_Add INSTALL_COMMAND.

125d6ef

Also revert previous fix for Issue #25.

sreeharihegden added a commit that referenced this issue


          Fix for Issue #34: Update gateway() calls to use packaged name.

334b366

Also fixes Issues #25, #28.

sreeharihegden added a commit that referenced this issue


          Move libmexclass install steps to ExternalProject_Add INSTALL_COMMAND.

50a5936

Also revert previous fix for Issue #25.

sreeharihegden added a commit that referenced this issue


          Fix for Issue #34: Update gateway() calls to use packaged name.

7981d72

Also fixes Issues #25, #28.

sreeharihegden added a commit that referenced this issue


          Move libmexclass install steps to ExternalProject_Add INSTALL_COMMAND.

01b5e29

Also revert previous fix for Issue #25.

sreeharihegden added a commit that referenced this issue


          Fix for Issue #34: Update gateway() calls to use packaged name.

def6862

Also fixes Issues #25, #28.

sreeharihegden added a commit that referenced this issue


          Move libmexclass install steps to ExternalProject_Add INSTALL_COMMAND.

c7f4424

Also revert previous fix for Issue #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment