Resolve latest release issue #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameagen-MW
approved these changes
Jan 7, 2025
| @@ -49,7 +49,7 @@ public MatlabInstaller(String id) { | |||
| } | |||
|
|
|||
| public String getRelease() { | |||
| return this.release.trim(); | |||
| return this.release; | |||
There was a problem hiding this comment.
What cases caused the removal of the trim here?
There was a problem hiding this comment.
Ah I see, it's just trimmed later.
There was a problem hiding this comment.
Yeah, mostly just that it seems weird for a getter to change the value of the property. We were already trimming later so I just removed it.
|
Not sure what's going on with the flaky macos test |
davidbuzinski
merged commit 7afc938
into
2.16.0-SNAPSHOT-Qualification
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve latest release and use that to determine name of MATLAB folder. Also revert change where I bumped version in
pom.xmlbecause Vahila said that's part of the release process.#392