Support updating (while retaining ids) on cast_polymorphic_embed for polymorphic_embeds_many.
#95
Conversation
Update supported elixir and erlang versions
Remove support for MFA :with option
Co-authored-by: Alex Naser <[email protected]>
* Expand types aliases to avoid compile-time deps * Add tests to cover :types defined via map --------- Co-authored-by: Alex Naser <[email protected]>
chore: remove phoenix integration
Right now `cast_polymorphic_embed` for `polymorphic_embeds_many`, only creates new structs from the module and ignores the data provided (normally the first argument of a changeset/2 function). This leads to creating new ids for each and every update when it's not required. This MR fixes this.
|
Thank you for the work, few questions: @naserca Why did you remove support for MFA @Miradorn Why did you remove the dependencies on phoenix html/phoenix ecto/phoenix live view in the mix file? Anyway the changes have been added in the lib. Thank you |
|
@naserca Okay found the deprecation notice of using MFA in Ecto |
|
Hi @mathieuprog , thanks for following up and taking some time to work on this! IIRC I removed the phoenix_html related code due to a problem when we updated I think it might be worthwhile to extract the phoenix_html specific code into its own package ( In the end it's obviously your call! Thanks again for the great library and the work ❤️ |
|
Thank you for the clarifications. Taking note of the suggestion to isolate the helpers, feel free to contribute it or I'll address this later. In the meanwhile all of the changes from your branch have been added. I also noticed your comment here #74 (comment) but we would need a failing test. Again welcome to add it, or I'll address this later as well. If the comment is related to the issue, this would allow us to understand the limitation we have with custom Ecto Type and either see if anything can be done on Ecto's side, or at the minimum document this limitation. |
|
I would love to spent some time, but I'm going on parental leave next week for 4 months, so I'm currently pretty swamped finishing up work and preparing handover. Once I'm getting back and something needs work/help I'll be glad to jump onto it! |
|
Congrats to you then:) Enjoy your parental leave |
No description provided.